Skip to content

Commit

Permalink
VPN no longer binds to a fixed listening port (#2992)
Browse files Browse the repository at this point in the history
Task/Issue URL:
https://app.asana.com/0/1207603085593419/1207825471514017/f

iOS PR: Will integrate this to iOS main once released. iOS doesn't need
this with urgency.
BSK PR: duckduckgo/BrowserServicesKit#901

## Description

We were specifying a listening port for WireGuard, which is not a good
idea for a VPN client both for technical and security reasons.
  • Loading branch information
diegoreymendez authored Jul 18, 2024
1 parent ba87b24 commit fb46349
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion DuckDuckGo.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -13310,7 +13310,7 @@
repositoryURL = "https://github.com/duckduckgo/BrowserServicesKit";
requirement = {
kind = exactVersion;
version = 171.1.1;
version = "171.1.1-1";
};
};
9FF521422BAA8FF300B9819B /* XCRemoteSwiftPackageReference "lottie-spm" */ = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@
"kind" : "remoteSourceControl",
"location" : "https://github.com/duckduckgo/BrowserServicesKit",
"state" : {
"revision" : "298e20a06c5a60f5ccf85bce9f0930b36779ab74",
"version" : "171.1.1"
"revision" : "eea55b8903389f680c4f08667d8f1428e12aa053",
"version" : "171.1.1-1"
}
},
{
Expand Down
2 changes: 1 addition & 1 deletion LocalPackages/DataBrokerProtection/Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ let package = Package(
targets: ["DataBrokerProtection"])
],
dependencies: [
.package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "171.1.1"),
.package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "171.1.1-1"),
.package(path: "../SwiftUIExtensions"),
.package(path: "../XPCHelper"),
],
Expand Down
2 changes: 1 addition & 1 deletion LocalPackages/NetworkProtectionMac/Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ let package = Package(
.library(name: "VPNAppLauncher", targets: ["VPNAppLauncher"]),
],
dependencies: [
.package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "171.1.1"),
.package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "171.1.1-1"),
.package(url: "https://github.com/airbnb/lottie-spm", exact: "4.4.3"),
.package(path: "../AppLauncher"),
.package(path: "../UDSHelper"),
Expand Down
2 changes: 1 addition & 1 deletion LocalPackages/SubscriptionUI/Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ let package = Package(
targets: ["SubscriptionUI"]),
],
dependencies: [
.package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "171.1.1"),
.package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "171.1.1-1"),
.package(path: "../SwiftUIExtensions")
],
targets: [
Expand Down

0 comments on commit fb46349

Please sign in to comment.