Fire a pixel directly from PreferencesDuckPlayerView

duckduckgo · May 9, 2024 · fa0a381 · fa0a381
1 parent 2e70915
commit fa0a381
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 10 deletions.
diff --git a/DuckDuckGo/Preferences/Model/DuckPlayerPreferences.swift b/DuckDuckGo/Preferences/Model/DuckPlayerPreferences.swift
@@ -49,16 +49,6 @@ final class DuckPlayerPreferences: ObservableObject {
     var duckPlayerMode: DuckPlayerMode {
         didSet {
             persistor.duckPlayerModeBool = duckPlayerMode.boolValue
-            if oldValue != duckPlayerMode {
-                switch duckPlayerMode {
-                case .enabled:
-                    PixelKit.fire(GeneralPixel.duckPlayerSettingAlwaysSettings)
-                case .alwaysAsk:
-                    PixelKit.fire(GeneralPixel.duckPlayerSettingBackToDefault)
-                case .disabled:
-                    PixelKit.fire(GeneralPixel.duckPlayerSettingNeverSettings)
-                }
-            }
         }
     }
 

diff --git a/DuckDuckGo/Preferences/View/PreferencesDuckPlayerView.swift b/DuckDuckGo/Preferences/View/PreferencesDuckPlayerView.swift
@@ -17,6 +17,7 @@
 //
 
 import PreferencesViews
+import PixelKit
 import SwiftUI
 import SwiftUIExtensions
 
@@ -30,6 +31,14 @@ extension Preferences {
                 model.duckPlayerMode
             } set: { newValue in
                 model.duckPlayerMode = newValue
+                switch model.duckPlayerMode {
+                case .enabled:
+                    PixelKit.fire(GeneralPixel.duckPlayerSettingAlwaysSettings)
+                case .alwaysAsk:
+                    PixelKit.fire(GeneralPixel.duckPlayerSettingBackToDefault)
+                case .disabled:
+                    PixelKit.fire(GeneralPixel.duckPlayerSettingNeverSettings)
+                }
             }
         }