-
Notifications
You must be signed in to change notification settings - Fork 13
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Bookmark all tabs - Context menu (#2599)
Task/Issue URL: https://app.asana.com/0/0/1207032400501906/f **Description**: Add the new “Bookmark All Tabs…” menu item to: 1. Main application Menu -> Bookmarks menu. 2. The more options menu, the menu shown from the “…” button. 3. The contextual menu of a single Tab.
- Loading branch information
1 parent
d0fb45d
commit dd83ac7
Showing
17 changed files
with
326 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| // | ||
| // MoreOptionsMenu+BookmarksTests.swift | ||
| // | ||
| // Copyright © 2024 DuckDuckGo. All rights reserved. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| // | ||
|
|
||
| import XCTest | ||
| @testable import DuckDuckGo_Privacy_Browser | ||
|
|
||
| @MainActor | ||
| final class MoreOptionsMenu_BookmarksTests: XCTestCase { | ||
|
|
||
| func testWhenBookmarkSubmenuIsInitThenBookmarkAllTabsKeyIsCmdShiftD() throws { | ||
| // GIVEN | ||
| let sut = BookmarksSubMenu(targetting: self, tabCollectionViewModel: .init()) | ||
|
|
||
| // WHEN | ||
| let result = try XCTUnwrap(sut.item(withTitle: UserText.bookmarkAllTabs)) | ||
|
|
||
| // THEN | ||
| XCTAssertEqual(result.keyEquivalent, "d") | ||
| XCTAssertEqual(result.keyEquivalentModifierMask, [.command, .shift]) | ||
| } | ||
|
|
||
| func testWhenTabCollectionCanBookmarkAllTabsThenBookmarkAllTabsMenuItemIsEnabled() throws { | ||
| // GIVEN | ||
| let tab1 = Tab(content: .url(.duckDuckGo, credential: nil, source: .ui)) | ||
| let tab2 = Tab(content: .url(.duckDuckGoEmail, credential: nil, source: .ui)) | ||
| let sut = BookmarksSubMenu(targetting: self, tabCollectionViewModel: .init(tabCollection: .init(tabs: [tab1, tab2]))) | ||
|
|
||
| // WHEN | ||
| let result = try XCTUnwrap(sut.item(withTitle: UserText.bookmarkAllTabs)) | ||
|
|
||
| // THEN | ||
| XCTAssertTrue(result.isEnabled) | ||
| } | ||
|
|
||
| func testWhenTabCollectionCannotBookmarkAllTabsThenBookmarkAllTabsMenuItemIsDisabled() throws { | ||
| // GIVEN | ||
| let sut = BookmarksSubMenu(targetting: self, tabCollectionViewModel: .init(tabCollection: .init(tabs: []))) | ||
|
|
||
| // WHEN | ||
| let result = try XCTUnwrap(sut.item(withTitle: UserText.bookmarkAllTabs)) | ||
|
|
||
| // THEN | ||
| XCTAssertFalse(result.isEnabled) | ||
| } | ||
|
|
||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.