maliciousSiteProtectionErrorPage feature flag -> maliciousSiteProtection

duckduckgo · Dec 10, 2024 · d4c60ee · d4c60ee
1 parent 890480a
commit d4c60ee
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/DuckDuckGo/MaliciousSiteProtection/MaliciousSiteProtectionManager.swift b/DuckDuckGo/MaliciousSiteProtection/MaliciousSiteProtectionManager.swift
@@ -125,14 +125,14 @@ public class MaliciousSiteProtectionManager: MaliciousSiteDetecting {
     }
 
     private func setupBindings() {
-        if featureFlagger.isFeatureOn(.maliciousSiteProtectionErrorPage) {
+        if featureFlagger.isFeatureOn(.maliciousSiteProtection) {
             subscribeToDetectionPreferences()
             return
         }
 
         guard let overridesHandler = featureFlagger.localOverrides?.actionHandler as? FeatureFlagOverridesPublishingHandler<FeatureFlag> else { return }
         featureFlagsCancellable = overridesHandler.flagDidChangePublisher
-            .filter { $0.0 == .maliciousSiteProtectionErrorPage }
+            .filter { $0.0 == .maliciousSiteProtection }
             .sink { [weak self] change in
                 guard let self else { return }
                 if change.1 {

diff --git a/DuckDuckGo/Preferences/View/PreferencesGeneralView.swift b/DuckDuckGo/Preferences/View/PreferencesGeneralView.swift
@@ -196,7 +196,7 @@ extension Preferences {
                 }
 
                 // SECTION 7: Phishing Detection
-                if featureFlagger.isFeatureOn(.maliciousSiteProtectionErrorPage) {
+                if featureFlagger.isFeatureOn(.maliciousSiteProtection) {
                     PreferencePaneSection(UserText.maliciousSiteDetectionHeader, spacing: 0) {
                         PreferencePaneSubSection {
                             ToggleMenuItem(UserText.maliciousSiteDetectionIsEnabled,

diff --git a/LocalPackages/FeatureFlags/Sources/FeatureFlags/FeatureFlag.swift b/LocalPackages/FeatureFlags/Sources/FeatureFlags/FeatureFlag.swift
@@ -22,7 +22,7 @@ import BrowserServicesKit
 public enum FeatureFlag: String, CaseIterable {
     case debugMenu
     case sslCertificatesBypass
-    case maliciousSiteProtectionErrorPage
+    case maliciousSiteProtection
 
     /// Add experimental atb parameter to SERP queries for internal users to display Privacy Reminder
     /// https://app.asana.com/0/1199230911884351/1205979030848528/f
@@ -59,7 +59,7 @@ extension FeatureFlag: FeatureFlagDescribing {
         case .htmlNewTabPage,
              .isPrivacyProLaunchedROWOverride:
             return true
-        case .maliciousSiteProtectionErrorPage:
+        case .maliciousSiteProtection:
             return true
         case .autofillPartialFormSaves:
             return true
@@ -89,8 +89,8 @@ extension FeatureFlag: FeatureFlagDescribing {
             return .remoteReleasable(.subfeature(AutofillSubfeature.unknownUsernameCategorization))
         case .freemiumDBP:
             return .remoteReleasable(.subfeature(DBPSubfeature.freemium))
-        case .maliciousSiteProtectionErrorPage:
-            return .remoteReleasable(.subfeature(MaliciousSiteProtectionSubfeature.allowErrorPage))
+        case .maliciousSiteProtection:
+            return .remoteReleasable(.feature(.maliciousSiteProtection))
         case .contextualOnboarding:
             return .remoteReleasable(.feature(.contextualOnboarding))
         case .credentialsImportPromotionForExistingUsers: