Skip to content

Commit

Permalink
Fix VPN toggle failures (#2892)
Browse files Browse the repository at this point in the history
Task/Issue URL:
https://app.asana.com/0/1207603085593419/1207629954356116/f

iOS PR: duckduckgo/iOS#2979
BSK PR: duckduckgo/BrowserServicesKit#858

## Description

The VPN toggle is sometimes failing silently, apparently due to a race
condition created by calls to `sendProviderMessage` while the VPN is
starting up.

This PR changes our logic to limit when those calls are made, since none
of them make sense to call when the VPN is connecting.
  • Loading branch information
diegoreymendez authored Jun 21, 2024
1 parent 43d9bfd commit c712413
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion DuckDuckGo.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -13022,7 +13022,7 @@
repositoryURL = "https://github.com/duckduckgo/BrowserServicesKit";
requirement = {
kind = exactVersion;
version = "156.0.0-1";
version = "156.0.0-2";
};
};
9FF521422BAA8FF300B9819B /* XCRemoteSwiftPackageReference "lottie-spm" */ = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@
"kind" : "remoteSourceControl",
"location" : "https://github.com/duckduckgo/BrowserServicesKit",
"state" : {
"revision" : "5362ffc520cbd2579b02c5a9fbdf808e5d75ae95",
"version" : "156.0.0-1"
"revision" : "2806adf8cae5bffebf0cf5043210f29bac0bade1",
"version" : "156.0.0-2"
}
},
{
Expand Down
2 changes: 1 addition & 1 deletion LocalPackages/DataBrokerProtection/Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ let package = Package(
targets: ["DataBrokerProtection"])
],
dependencies: [
.package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "156.0.0-1"),
.package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "156.0.0-2"),
.package(path: "../SwiftUIExtensions"),
.package(path: "../XPCHelper"),
],
Expand Down
2 changes: 1 addition & 1 deletion LocalPackages/NetworkProtectionMac/Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ let package = Package(
.library(name: "VPNAppLauncher", targets: ["VPNAppLauncher"]),
],
dependencies: [
.package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "156.0.0-1"),
.package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "156.0.0-2"),
.package(url: "https://github.com/airbnb/lottie-spm", exact: "4.4.1"),
.package(path: "../AppLauncher"),
.package(path: "../UDSHelper"),
Expand Down
2 changes: 1 addition & 1 deletion LocalPackages/SubscriptionUI/Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ let package = Package(
targets: ["SubscriptionUI"]),
],
dependencies: [
.package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "156.0.0-1"),
.package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "156.0.0-2"),
.package(path: "../SwiftUIExtensions")
],
targets: [
Expand Down

0 comments on commit c712413

Please sign in to comment.