Zoom PDF controls (#3204)

Task/Issue URL: https://app.asana.com/0/276630244458377/1208206662726272/f
duckduckgo · Sep 4, 2024 · ad8f05f · ad8f05f
1 parent 7108c78
commit ad8f05f
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 2 deletions.
diff --git a/DuckDuckGo/Common/Extensions/WKPDFHUDViewWrapper.swift b/DuckDuckGo/Common/Extensions/WKPDFHUDViewWrapper.swift
@@ -27,7 +27,12 @@ struct WKPDFHUDViewWrapper {
     static let performActionForControlSelector = NSSelectorFromString("_performActionForControl:")
     static let visibleKey = "_visible"
     static let setVisibleSelector = NSSelectorFromString("_setVisible:")
-    static let savePDFControlId = "arrow.down.circle"
+
+    private enum ControlId: String {
+        case savePDF = "arrow.down.circle"
+        case zoomIn = "plus.magnifyingglass"
+        case zoomOut = "minus.magnifyingglass"
+    }
 
     private let hudView: NSView
 
@@ -72,14 +77,26 @@ struct WKPDFHUDViewWrapper {
     }
 
     func savePDF() {
+        performAction(for: .savePDF)
+    }
+
+    func zoomIn() {
+        performAction(for: .zoomIn)
+    }
+
+    func zoomOut() {
+        performAction(for: .zoomOut)
+    }
+
+    private func performAction(for controlId: ControlId) {
         let wasVisible = isVisible
         self.setIsVisibleIVar(true)
         defer {
             if !wasVisible {
                 self.setIsVisibleIVar(false)
             }
         }
-        hudView.perform(Self.performActionForControlSelector, with: Self.savePDFControlId)
+        hudView.perform(Self.performActionForControlSelector, with: controlId.rawValue)
     }
 
     // try to set _visible ivar value directly to avoid actually showing the HUD

diff --git a/DuckDuckGo/Tab/View/WebView.swift b/DuckDuckGo/Tab/View/WebView.swift
@@ -139,12 +139,22 @@ final class WebView: WKWebView {
     }
 
     func zoomIn() {
+        // if displaying PDF
+        if let pdfHudView = self.hudView() {
+            pdfHudView.zoomIn()
+            return
+        }
         guard canZoomIn else { return }
         zoomLevel = DefaultZoomValue.allCases[self.zoomLevel.index + 1]
         zoomLevelDelegate?.zoomWasSet(to: zoomLevel)
     }
 
     func zoomOut() {
+        // if displaying PDF
+        if let pdfHudView = self.hudView() {
+            pdfHudView.zoomOut()
+            return
+        }
         guard canZoomOut else { return }
         zoomLevel = DefaultZoomValue.allCases[self.zoomLevel.index - 1]
         zoomLevelDelegate?.zoomWasSet(to: zoomLevel)