Skip to content

Commit

Permalink
autofill: don't prefix autofill email pixels with m.mac. (#2808)
Browse files Browse the repository at this point in the history
Task/Issue URL:
https://app.asana.com/0/1206682621538333/1207380134103391/f
Tech Design URL: N/A

Pixels fired for email autofill use-cases are intentionally not prefixed
with `m.mac.`, though the historical reason isn't clear to me. The
migration to PixelKit for pixel management[^1] caused those
email-related pixels to be prefixed. Wrap email-related JS pixels in
`NonStandardEvent`s to prevent that prefixing, to restore their original
intended names.

[^1]: d885fd0 (PixelKit adoption (#2557), 2024-04-17)
  • Loading branch information
sjbarag authored May 23, 2024
1 parent 41a9790 commit a3d04ea
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion DuckDuckGo/Autofill/ContentOverlayViewController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ extension ContentOverlayViewController: SecureVaultManagerDelegate {

self.emailManager.updateLastUseDate()

PixelKit.fire(GeneralPixel.jsPixel(pixel), withAdditionalParameters: pixelParameters)
PixelKit.fire(NonStandardEvent(GeneralPixel.jsPixel(pixel)), withAdditionalParameters: pixelParameters)
} else {
PixelKit.fire(GeneralPixel.jsPixel(pixel), withAdditionalParameters: pixel.pixelParameters)
}
Expand Down

0 comments on commit a3d04ea

Please sign in to comment.