add facke experiment

duckduckgo · Dec 6, 2024 · 911fec7 · 911fec7
1 parent 786ca2d
commit 911fec7
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 4 deletions.
diff --git a/DuckDuckGo.xcodeproj/project.pbxproj b/DuckDuckGo.xcodeproj/project.pbxproj
@@ -15370,8 +15370,8 @@
 			isa = XCRemoteSwiftPackageReference;
 			repositoryURL = "https://github.com/duckduckgo/BrowserServicesKit";
 			requirement = {
-				kind = exactVersion;
-				version = 218.0.0;
+				branch = "sabrina/setup-experiment-test";
+				kind = branch;
 			};
 		};
 		9FF521422BAA8FF300B9819B /* XCRemoteSwiftPackageReference "lottie-spm" */ = {

diff --git a/DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved b/DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
@@ -32,8 +32,8 @@
       "kind" : "remoteSourceControl",
       "location" : "https://github.com/duckduckgo/BrowserServicesKit",
       "state" : {
-        "revision" : "e5d390c8559fbe7b1ca67fd3982c91bcc0437d60",
-        "version" : "218.0.0"
+        "branch" : "sabrina/setup-experiment-test",
+        "revision" : "a294718068171e3517d7a1b2351f6ba53ff61d44"
       }
     },
     {

diff --git a/DuckDuckGo/HomePage/Model/HomePageContinueSetUpModel.swift b/DuckDuckGo/HomePage/Model/HomePageContinueSetUpModel.swift
@@ -158,6 +158,9 @@ extension HomePage.Models {
             // HTML NTP doesn't refresh on appear so we have to connect to the appear signal
             // (the notification in this case) to trigger a refresh.
             NotificationCenter.default.addObserver(self, selector: #selector(refreshFeaturesForHTMLNewTabPage(_:)), name: .newTabPageWebViewDidAppear, object: nil)
+
+            // This is just temporarily here to run an A/A test to check the new experiment framework works as expected
+            _ = Application.appDelegate.featureFlagger.getCohortIfEnabled(for: CredentialsSavingFlag())
         }
 
         @MainActor func performAction(for featureType: FeatureType) {
@@ -445,3 +448,19 @@ extension AppVersion {
         return "\(components[0]).\(components[1])"
     }
 }
+
+// This is just temporarily here to run an A/A test to check the new experiment framework works as expected
+public struct CredentialsSavingFlag: FeatureFlagExperimentDescribing {
+    public init() {}
+
+    public typealias CohortType = Cohort
+
+    public var rawValue = "credentialSaving"
+
+    public var source: FeatureFlagSource = .remoteReleasable(.subfeature(ExperimentTestSubfeatures.experimentTestAA))
+
+    public enum Cohort: String, FlagCohort {
+        case control
+        case blue
+    }
+}