Add a feature flag for the location prefs

duckduckgo · Dec 15, 2023 · 864bcf9 · 864bcf9
1 parent 9278ee9
commit 864bcf9
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 4 deletions.
diff --git a/DuckDuckGo/FeatureFlagging/Model/FeatureFlag.swift b/DuckDuckGo/FeatureFlagging/Model/FeatureFlag.swift
@@ -25,6 +25,8 @@ public enum FeatureFlag: String {
     /// Add experimental atb parameter to SERP queries for internal users to display Privacy Reminder
     /// https://app.asana.com/0/1199230911884351/1205979030848528/f
     case appendAtbToSerpQueries
+
+    case vpnGeoswitching
 }
 
 extension FeatureFlag: FeatureFlagSourceProviding {
@@ -34,6 +36,8 @@ extension FeatureFlag: FeatureFlagSourceProviding {
             return .internalOnly
         case .appendAtbToSerpQueries:
             return .internalOnly
+        case .vpnGeoswitching:
+            return .internalOnly
         }
     }
 }

diff --git a/DuckDuckGo/Preferences/Model/VPNPreferencesModel.swift b/DuckDuckGo/Preferences/Model/VPNPreferencesModel.swift
@@ -23,9 +23,11 @@ import Combine
 import Foundation
 import NetworkProtection
 import NetworkProtectionUI
+import BrowserServicesKit
 
 final class VPNPreferencesModel: ObservableObject {
 
+    let shouldShowLocationItem: Bool
     @Published var locationItem: VPNLocationPreferenceItemModel
 
     @Published var alwaysON = true
@@ -68,7 +70,8 @@ final class VPNPreferencesModel: ObservableObject {
     private var cancellables = Set<AnyCancellable>()
 
     init(settings: VPNSettings = .init(defaults: .netP),
-         defaults: UserDefaults = .netP) {
+         defaults: UserDefaults = .netP,
+         featureFlagger: FeatureFlagger = NSApp.delegateTyped.featureFlagger) {
         self.settings = settings
 
         connectOnLogin = settings.connectOnLogin
@@ -78,6 +81,7 @@ final class VPNPreferencesModel: ObservableObject {
         showUninstallVPN = defaults.networkProtectionOnboardingStatus != .default
         onboardingStatus = defaults.networkProtectionOnboardingStatus
         locationItem = VPNLocationPreferenceItemModel(selectedLocation: settings.selectedLocation)
+        shouldShowLocationItem = featureFlagger.isFeatureOn(.vpnGeoswitching)
 
         subscribeToOnboardingStatusChanges(defaults: defaults)
         subscribeToLocationSettingChanges()

diff --git a/DuckDuckGo/Preferences/View/PreferencesVPNView.swift b/DuckDuckGo/Preferences/View/PreferencesVPNView.swift
@@ -33,9 +33,11 @@ extension Preferences {
 
                 TextMenuTitle(text: UserText.vpn)
 
-                PreferencePaneSection {
-                    TextMenuItemHeader(text: UserText.vpnLocationTitle)
-                    VPNLocationPreferenceItem(model: model.locationItem)
+                if model.shouldShowLocationItem {
+                    PreferencePaneSection {
+                        TextMenuItemHeader(text: UserText.vpnLocationTitle)
+                        VPNLocationPreferenceItem(model: model.locationItem)
+                    }
                 }
 
                 // SECTION: Manage VPN