Increase ratio of complete form saves (#3649)

Task/Issue URL: https://app.asana.com/0/0/1206048666874235/f

**Description**:

Increase ratio of complete credentials saves (i.e. that include the
username) by checking for recently filled emails/usernames when a form
save event is incomplete.

Approach is to have a new form save events for username/email-only forms
that stays in memory for 3 minutes. If a password-only form save is
detected for the same domain, we can complete the form with the previous
partial data. This would also cover mobile where we don't have
identities autofill – and in general in all cases where the user inputs
data manually.

**Optional E2E tests**:
- [ ] Run PIR E2E tests
Check this to run the Personal Information Removal end to end tests. If
updating CCF, or any PIR related code, tick this.

**Steps to test this PR**:
https://app.asana.com/0/1202926619870900/1208866651723703/f

<!--
Tagging instructions
If this PR isn't ready to be merged for whatever reason it should be
marked with the `DO NOT MERGE` label (particularly if it's a draft)
If it's pending Product Review/PFR, please add the `Pending Product
Review` label.

If at any point it isn't actively being worked on/ready for
review/otherwise moving forward (besides the above PR/PFR exception)
strongly consider closing it (or not opening it in the first place). If
you decide not to close it, make sure it's labelled to make it clear the
PRs state and comment with more information.
-->

**Definition of Done**:

* [ ] Does this PR satisfy our [Definition of
Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)?

---
###### Internal references:
[Pull Request Review
Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f)
[Software Engineering
Expectations](https://app.asana.com/0/59792373528535/199064865822552)
[Technical Design
Template](https://app.asana.com/0/59792373528535/184709971311943)
[Pull Request
Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f)

DuckDuckGo.xcodeproj/project.pbxproj

@@ -15225,7 +15225,7 @@
 			repositoryURL = "https://github.com/duckduckgo/BrowserServicesKit";
 			requirement = {
 				kind = exactVersion;
-				version = 218.1.0;
+				version = 219.0.0;
 			};
 		};
 		9FF521422BAA8FF300B9819B /* XCRemoteSwiftPackageReference "lottie-spm" */ = {

DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved

@@ -32,8 +32,8 @@
       "kind" : "remoteSourceControl",
       "location" : "https://github.com/duckduckgo/BrowserServicesKit",
       "state" : {
-        "revision" : "a82c14b991f8cbef46d4b7d8e613762f1592fcd2",
-        "version" : "218.1.0"
+        "revision" : "20df9e22d5a69acfc25204fb0228a9d6f79b721f",
+        "version" : "219.0.0"
       }
     },
     {

DuckDuckGo/Autofill/ContentOverlayViewController.swift

@@ -39,9 +39,12 @@ public final class ContentOverlayViewController: NSViewController, EmailManagerR
         return emailManager
     }()
 
+    lazy var featureFlagger = NSApp.delegateTyped.featureFlagger
+
     lazy var vaultManager: SecureVaultManager = {
         let manager = SecureVaultManager(passwordManager: PasswordManagerCoordinator.shared,
                                          includePartialAccountMatches: true,
+                                         shouldAllowPartialFormSaves: featureFlagger.isFeatureOn(.autofillPartialFormSaves),
                                          tld: ContentBlocking.shared.tld)
         manager.delegate = self
         return manager

DuckDuckGo/SecureVault/View/SaveCredentialsViewController.swift

@@ -487,13 +487,16 @@ final class SaveCredentialsViewController: NSViewController {
     }
 
     private func evaluateCredentialsAndFirePixels(for action: Action, credentials: SecureVaultModels.WebsiteCredentials?) {
+        let backfilledKey = GeneralPixel.AutofillParameterKeys.backfilled
         switch action {
         case .displayed:
             if let credentials = credentials {
                 if isPasswordUpdated(credentials: credentials) {
-                    PixelKit.fire(GeneralPixel.autofillLoginsUpdatePasswordInlineDisplayed)
+                    let backfilled = credentials.password.flatMap { String(data: $0, encoding: .utf8) }.isNilOrEmpty
+                    PixelKit.fire(GeneralPixel.autofillLoginsUpdatePasswordInlineDisplayed, withAdditionalParameters: [backfilledKey: String(describing: backfilled)])
                 } else {
-                    PixelKit.fire(GeneralPixel.autofillLoginsUpdateUsernameInlineDisplayed)
+                    let backfilled = credentials.account.username.isNilOrEmpty
+                    PixelKit.fire(GeneralPixel.autofillLoginsUpdateUsernameInlineDisplayed, withAdditionalParameters: [backfilledKey: String(describing: backfilled)])
                 }
             } else {
                 if usernameField.stringValue.trimmingWhitespace().isEmpty {
@@ -505,14 +508,18 @@ final class SaveCredentialsViewController: NSViewController {
         case .confirmed, .dismissed:
             if let credentials = credentials {
                 if isUsernameUpdated(credentials: credentials) {
+                    let backfilled = credentials.account.username.isNilOrEmpty
                     firePixel(for: action,
                               confirmedPixel: GeneralPixel.autofillLoginsUpdateUsernameInlineConfirmed,
-                              dismissedPixel: GeneralPixel.autofillLoginsUpdateUsernameInlineDismissed)
+                              dismissedPixel: GeneralPixel.autofillLoginsUpdateUsernameInlineDismissed,
+                              withAdditionalParameters: [backfilledKey: String(describing: backfilled)])
                 }
                 if isPasswordUpdated(credentials: credentials) {
+                    let backfilled = credentials.password.flatMap { String(data: $0, encoding: .utf8) }.isNilOrEmpty
                     firePixel(for: action,
                               confirmedPixel: GeneralPixel.autofillLoginsUpdatePasswordInlineConfirmed,
-                              dismissedPixel: GeneralPixel.autofillLoginsUpdatePasswordInlineDismissed)
+                              dismissedPixel: GeneralPixel.autofillLoginsUpdatePasswordInlineDismissed,
+                              withAdditionalParameters: [backfilledKey: String(describing: backfilled)])
                 }
             } else {
                 if usernameField.stringValue.trimmingWhitespace().isEmpty {
@@ -528,9 +535,9 @@ final class SaveCredentialsViewController: NSViewController {
         }
     }
 
-    private func firePixel(for action: Action, confirmedPixel: PixelKitEventV2, dismissedPixel: PixelKitEventV2) {
+    private func firePixel(for action: Action, confirmedPixel: PixelKitEventV2, dismissedPixel: PixelKitEventV2, withAdditionalParameters parameters: [String: String]? = nil) {
         let pixel = action == .confirmed ? confirmedPixel : dismissedPixel
-        PixelKit.fire(pixel)
+        PixelKit.fire(pixel, withAdditionalParameters: parameters)
     }
 
 }

DuckDuckGo/Statistics/GeneralPixel.swift

@@ -1442,4 +1442,8 @@ enum GeneralPixel: PixelKitEventV2 {
         }
 
     }
+
+    enum AutofillParameterKeys {
+        static var backfilled = "backfilled"
+    }
 }

DuckDuckGo/Tab/TabExtensions/AutofillTabExtension.swift

@@ -30,9 +30,12 @@ final class AutofillTabExtension: TabExtension {
         return emailManager
     }
 
+    static var featureFlagger = NSApp.delegateTyped.featureFlagger
+
     static var vaultManagerProvider: (SecureVaultManagerDelegate) -> AutofillSecureVaultDelegate = { delegate in
         let manager = SecureVaultManager(passwordManager: PasswordManagerCoordinator.shared,
                                          includePartialAccountMatches: true,
+                                         shouldAllowPartialFormSaves: featureFlagger.isFeatureOn(.autofillPartialFormSaves),
                                          tld: ContentBlocking.shared.tld)
         manager.delegate = delegate
         return manager

LocalPackages/DataBrokerProtection/Package.swift

@@ -29,7 +29,7 @@ let package = Package(
             targets: ["DataBrokerProtection"])
     ],
     dependencies: [
-        .package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "218.1.0"),
+        .package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "219.0.0"),
         .package(path: "../SwiftUIExtensions"),
         .package(path: "../AppKitExtensions"),
         .package(path: "../XPCHelper"),

LocalPackages/FeatureFlags/Package.swift

@@ -32,7 +32,7 @@ let package = Package(
             targets: ["FeatureFlags"]),
     ],
     dependencies: [
-        .package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "218.1.0"),
+        .package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "219.0.0"),
     ],
     targets: [
         // Targets are the basic building blocks of a package, defining a module or a test suite.

LocalPackages/FeatureFlags/Sources/FeatureFlags/FeatureFlag.swift

@@ -49,6 +49,8 @@ public enum FeatureFlag: String, CaseIterable {
 
     case isPrivacyProLaunchedROW
     case isPrivacyProLaunchedROWOverride
+
+    case autofillPartialFormSaves
 }
 
 extension FeatureFlag: FeatureFlagDescribing {
@@ -59,6 +61,8 @@ extension FeatureFlag: FeatureFlagDescribing {
             return true
         case .maliciousSiteProtectionErrorPage:
             return true
+        case .autofillPartialFormSaves:
+            return true
         case .debugMenu,
              .sslCertificatesBypass,
              .appendAtbToSerpQueries,
@@ -101,6 +105,8 @@ extension FeatureFlag: FeatureFlagDescribing {
             return .remoteReleasable(.subfeature(PrivacyProSubfeature.isLaunchedROW))
         case .isPrivacyProLaunchedROWOverride:
             return .remoteReleasable(.subfeature(PrivacyProSubfeature.isLaunchedROWOverride))
+        case .autofillPartialFormSaves:
+            return .remoteReleasable(.subfeature(AutofillSubfeature.partialFormSaves))
         }
     }
 }

LocalPackages/NetworkProtectionMac/Package.swift

@@ -32,7 +32,7 @@ let package = Package(
         .library(name: "VPNAppLauncher", targets: ["VPNAppLauncher"]),
     ],
     dependencies: [
-        .package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "218.1.0"),
+        .package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "219.0.0"),
         .package(url: "https://github.com/airbnb/lottie-spm", exact: "4.4.3"),
         .package(path: "../AppLauncher"),
         .package(path: "../UDSHelper"),

LocalPackages/NewTabPage/Package.swift

@@ -32,7 +32,7 @@ let package = Package(
             targets: ["NewTabPage"]),
     ],
     dependencies: [
-        .package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "218.1.0"),
+        .package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "219.0.0"),
         .package(path: "../WebKitExtensions"),
         .package(path: "../Utilities"),
     ],

LocalPackages/SubscriptionUI/Package.swift

@@ -12,7 +12,7 @@ let package = Package(
             targets: ["SubscriptionUI"]),
     ],
     dependencies: [
-        .package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "218.1.0"),
+        .package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "219.0.0"),
         .package(path: "../SwiftUIExtensions"),
         .package(path: "../FeatureFlags")
     ],

LocalPackages/WebKitExtensions/Package.swift

@@ -32,7 +32,7 @@ let package = Package(
         ),
     ],
     dependencies: [
-        .package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "218.1.0"),
+        .package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "219.0.0"),
         .package(path: "../AppKitExtensions")
     ],
     targets: [