-
Notifications
You must be signed in to change notification settings - Fork 12
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Handle subscription tabs state based on authentication events (#2372)
Task/Issue URL: https://app.asana.com/0/1199230911884351/1206726299874130/f **Description**: When reloading subscription purchase and welcome page should be refreshed based on the authentication state when signing out the subscription and ITR tabs should be closed. Additional considerations to facilitate above: - subscription and ITR tabs should disallow pin/bookmark/duplicate actions - when opening a new subscription tab the old one should be reused preventing multiple tabs of this type **Steps to test this PR**: Opening tabs on closing them on sign out 1. Purchase or restore a subscription. 2. Open subscription type page (e.g. add or mana email) 3. Try repeating opening a new subscription type tab, the previous one should be reused instead of opening a new one. 4. Open ITR page. 5. Try repeating opening a new ITR tab, the previous one should be reused instead of opening a new one. 6. Leave subscription and ITR tabs open 7. Remove subscription 8. subscription and ITR tabs should be closed Possible actions for subscription and ITR tabs: 1. Open subscription type page (e.g. add or mana email) 2. Right click on the tab. It should not be possible to pin/bookmark/duplicate it. 3. Open ITR page. 4. Right click on the tab. It should not be possible to pin/bookmark/duplicate it. Maintaining welcome page state: 1. Have a subscription welcome page open 2. Close and reopen the browser. 3. While having the up to date auth token the welcome page should not redirect elsewhere. Proper purchase/welcome page state upon restoration: 1. Purchase subscription via App Store 2. Remove the subscription 3. Open purchase page 4. Open settings 5. Click "I have a subscription" -> "Restore" to restore subscription 6. Switch to a purchase page that should reload to welcome page <!-- Tagging instructions If this PR isn't ready to be merged for whatever reason it should be marked with the `DO NOT MERGE` label (particularly if it's a draft) If it's pending Product Review/PFR, please add the `Pending Product Review` label. If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information. --> --- ###### Internal references: [Pull Request Review Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f) [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) [Pull Request Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f)
- Loading branch information
Showing
9 changed files
with
185 additions
and
33 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters