Skip to content

Commit

Permalink
fix autofill UI for long copy (#2241)
Browse files Browse the repository at this point in the history
Task/Issue URL:
https://app.asana.com/0/1199230911884351/1206628858529171/f

**Description**: Fix Ui to accomodate long copy (in preparation of
localisation)
  • Loading branch information
SabrinaTardio authored Feb 28, 2024
1 parent 3902c7c commit 2e024c5
Show file tree
Hide file tree
Showing 3 changed files with 69 additions and 48 deletions.
4 changes: 2 additions & 2 deletions DuckDuckGo/SecureVault/View/PasswordManagementItemList.swift
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,6 @@ struct PasswordManagementItemListCategoryView: View {
return 11
}

Spacer()

// MenuButton incorrectly displays a disabled state when you re-render it with a different image.
// According to Stack Overflow, this was fixed in macOS 12, but it can still be reproduced on 12.2.
// This also happens with Menu in macOS 11.0+, so using that on later macOS versions doesn't help.
Expand All @@ -135,8 +133,10 @@ struct PasswordManagementItemListCategoryView: View {

if model.sortDescriptor.order == .ascending {
PasswordManagementSortButton(imageName: "SortAscending")
.frame(width: 24)
} else {
PasswordManagementSortButton(imageName: "SortDescending")
.frame(width: 24)
}
}
.padding(.vertical, -4)
Expand Down
Loading

0 comments on commit 2e024c5

Please sign in to comment.