disable Pixel for Safari Bookmarks.plist read permission request (#2098)

Task/Issue URL: https://app.asana.com/0/0/1206403448888681/f
duckduckgo · Jan 22, 2024 · 2b8fc22 · 2b8fc22
1 parent 68b1114
commit 2b8fc22
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/DuckDuckGo/DataImport/Bookmarks/Safari/SafariDataImporter.swift b/DuckDuckGo/DataImport/Bookmarks/Safari/SafariDataImporter.swift
@@ -60,7 +60,7 @@ final class SafariDataImporter: DataImporter {
         }
     }
 
-    static private let bookmarksFileName = "Bookmarks.plist"
+    static let bookmarksFileName = "Bookmarks.plist"
 
     private var fileUrl: URL {
         profile.profileURL.appendingPathComponent(Self.bookmarksFileName)

diff --git a/DuckDuckGo/DataImport/Model/DataImportViewModel.swift b/DuckDuckGo/DataImport/Model/DataImportViewModel.swift
@@ -308,7 +308,10 @@ struct DataImportViewModel {
                     break
                 }
                 log("file read no permission for \(url.path)")
-                Pixel.fire(.dataImportFailed(source: importSource, sourceVersion: importSource.installedAppsMajorVersionDescription(selectedProfile: selectedProfile), error: importError))
+
+                if url != selectedProfile?.profileURL.appendingPathComponent(SafariDataImporter.bookmarksFileName) {
+                    Pixel.fire(.dataImportFailed(source: importSource, sourceVersion: importSource.installedAppsMajorVersionDescription(selectedProfile: selectedProfile), error: importError))
+                }
                 screen = .getReadPermission(url)
                 return true