Skip to content

Commit

Permalink
Remove entitlement from App Store review build.
Browse files Browse the repository at this point in the history
  • Loading branch information
samsymons committed Nov 8, 2024
1 parent c2909d8 commit 253d658
Show file tree
Hide file tree
Showing 3 changed files with 65 additions and 0 deletions.
1 change: 1 addition & 0 deletions Configuration/App/DuckDuckGoAppStore.xcconfig
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ PRODUCT_BUNDLE_IDENTIFIER = $(MAIN_BUNDLE_IDENTIFIER)
CODE_SIGN_ENTITLEMENTS = DuckDuckGo/DuckDuckGoAppStore.entitlements
CODE_SIGN_ENTITLEMENTS[config=Debug][arch=*][sdk=*] = DuckDuckGo/DuckDuckGoAppStoreDebug.entitlements
CODE_SIGN_ENTITLEMENTS[config=CI][arch=*][sdk=*] = DuckDuckGo/DuckDuckGoAppStoreCI.entitlements
CODE_SIGN_ENTITLEMENTS[config=Review][arch=*][sdk=*] = DuckDuckGo/DuckDuckGoAppStoreCI.entitlements

CODE_SIGN_IDENTITY[sdk=macosx*] = 3rd Party Mac Developer Application
CODE_SIGN_IDENTITY[config=Debug][sdk=macosx*] = Apple Development
Expand Down
2 changes: 2 additions & 0 deletions DuckDuckGo.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -3870,6 +3870,7 @@
4BA1A6F5258C4F9600F6F690 /* EncryptionMocks.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = EncryptionMocks.swift; sourceTree = "<group>"; };
4BA1A6FD258C5C1300F6F690 /* EncryptedValueTransformerTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = EncryptedValueTransformerTests.swift; sourceTree = "<group>"; };
4BA71ED92B4B81E80002EBCE /* AppVersionExtension.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = AppVersionExtension.swift; sourceTree = "<group>"; };
4BA808FF2CDE78F600338EE4 /* DuckDuckGoAppStoreReview.entitlements */ = {isa = PBXFileReference; lastKnownFileType = text.plist.entitlements; path = DuckDuckGoAppStoreReview.entitlements; sourceTree = "<group>"; };
4BB6CE5E26B77ED000EC5860 /* Cryptography.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = Cryptography.swift; sourceTree = "<group>"; };
4BB88B4425B7B55C006F6B06 /* DebugUserScript.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = DebugUserScript.swift; sourceTree = "<group>"; };
4BB88B4925B7B690006F6B06 /* SequenceExtensions.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SequenceExtensions.swift; sourceTree = "<group>"; };
Expand Down Expand Up @@ -7742,6 +7743,7 @@
37D9BBA329376EE8000B99F9 /* DuckDuckGoAppStore.entitlements */,
377E54382937B7C400780A0A /* DuckDuckGoAppStoreCI.entitlements */,
37E1116C2C578F1B00583C19 /* DuckDuckGoAppStoreDebug.entitlements */,
4BA808FF2CDE78F600338EE4 /* DuckDuckGoAppStoreReview.entitlements */,
4B5F15032A1570F10060320F /* DuckDuckGoDebug.entitlements */,
4B65143C26392483005B46EB /* Email */,
B68412192B6A16030092F66A /* ErrorPage */,
Expand Down
62 changes: 62 additions & 0 deletions DuckDuckGo/DuckDuckGoAppStoreReview.entitlements
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>com.apple.developer.networking.networkextension</key>
<array>
<string>packet-tunnel-provider</string>
<string>app-proxy-provider</string>
</array>
<key>com.apple.security.app-sandbox</key>
<true/>
<key>com.apple.security.application-groups</key>
<array>
<string>$(IPC_APP_GROUP)</string>
<string>$(DBP_APP_GROUP)</string>
<string>$(NETP_APP_GROUP)</string>
<string>$(SUBSCRIPTION_APP_GROUP)</string>
<string>$(APP_CONFIGURATION_APP_GROUP)</string>
</array>
<key>com.apple.security.device.audio-input</key>
<true/>
<key>com.apple.security.device.camera</key>
<true/>
<key>com.apple.security.files.downloads.read-write</key>
<true/>
<key>com.apple.security.files.user-selected.read-write</key>
<true/>
<key>com.apple.security.network.client</key>
<true/>
<key>com.apple.security.personal-information.location</key>
<true/>
<key>com.apple.security.print</key>
<true/>
<key>com.apple.security.temporary-exception.files.home-relative-path.read-only</key>
<array>
<string>/Library/Application Support/Google/Chrome/</string>
<string>/Library/Application Support/BraveSoftware/Brave-Browser/</string>
<string>/Library/Application Support/Firefox/</string>
<string>/Library/Application Support/Microsoft Edge/</string>
<string>/Library/Application Support/Vivaldi/</string>
<string>/Library/Application Support/com.operasoftware.Opera/</string>
<string>/Library/Application Support/com.operasoftware.OperaGX/</string>
<string>/Library/Application Support/Yandex/YandexBrowser/</string>
<string>/Library/Application Support/Chromium/</string>
<string>/Library/Application Support/Coccoc/</string>
<string>/Library/Application Support/TorBrowser-Data/Browser/</string>
<string>/Library/Application Support/Arc/User Data/</string>
</array>
<key>com.apple.security.temporary-exception.mach-lookup.global-name</key>
<array>
<string>$(DBP_BACKGROUND_AGENT_BUNDLE_ID)</string>
<string>$(AGENT_BUNDLE_ID)</string>
</array>
<key>keychain-access-groups</key>
<array>
<string>$(DBP_APP_GROUP)</string>
<string>$(AppIdentifierPrefix)com.duckduckgo.mobile.ios</string>
<string>$(NETP_APP_GROUP)</string>
<string>$(SUBSCRIPTION_APP_GROUP)</string>
</array>
</dict>
</plist>

0 comments on commit 253d658

Please sign in to comment.