fix index out-of-bounds in startAttachingCrashLogMessages (#3006)

Task/Issue URL: https://app.asana.com/0/414709148257752/1207877553454228/f BSK PR: duckduckgo/BrowserServicesKit#906
duckduckgo · Jul 23, 2024 · 161d8d2 · 161d8d2
1 parent c0ee7b0
commit 161d8d2
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 24 deletions.
diff --git a/DuckDuckGo.xcodeproj/project.pbxproj b/DuckDuckGo.xcodeproj/project.pbxproj
@@ -13316,7 +13316,7 @@
 			repositoryURL = "https://github.com/duckduckgo/BrowserServicesKit";
 			requirement = {
 				kind = exactVersion;
-				version = "171.1.1-1";
+				version = "171.1.1-2";
 			};
 		};
 		9FF521422BAA8FF300B9819B /* XCRemoteSwiftPackageReference "lottie-spm" */ = {

diff --git a/DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved b/DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
@@ -32,8 +32,8 @@
       "kind" : "remoteSourceControl",
       "location" : "https://github.com/duckduckgo/BrowserServicesKit",
       "state" : {
-        "revision" : "eea55b8903389f680c4f08667d8f1428e12aa053",
-        "version" : "171.1.1-1"
+        "revision" : "ec7bfbcda3d18086a03d762c41382c318c699c8f",
+        "version" : "171.1.1-2"
       }
     },
     {

diff --git a/DuckDuckGo/Application/AppDelegate.swift b/DuckDuckGo/Application/AppDelegate.swift
@@ -144,25 +144,11 @@ final class AppDelegate: NSObject, NSApplicationDelegate {
     @UserDefaultsWrapper(key: .firstLaunchDate, defaultValue: Date.monthAgo)
     static var firstLaunchDate: Date
 
-    @UserDefaultsWrapper
-    private var didCrashDuringCrashHandlersSetUp: Bool
-
     static var isNewUser: Bool {
         return firstLaunchDate >= Date.weekAgo
     }
 
     override init() {
-        // will not add crash handlers and will fire pixel on applicationDidFinishLaunching if didCrashDuringCrashHandlersSetUp == true
-        let didCrashDuringCrashHandlersSetUp = UserDefaultsWrapper(key: .didCrashDuringCrashHandlersSetUp, defaultValue: false)
-        _didCrashDuringCrashHandlersSetUp = didCrashDuringCrashHandlersSetUp
-        if case .normal = NSApplication.runType,
-           !didCrashDuringCrashHandlersSetUp.wrappedValue {
-
-            didCrashDuringCrashHandlersSetUp.wrappedValue = true
-            CrashLogMessageExtractor.setUp()
-            didCrashDuringCrashHandlersSetUp.wrappedValue = false
-        }
-
         do {
             let encryptionKey = NSApplication.runType.requiresEnvironment ? try keyStore.readKey() : nil
             fileStore = EncryptedFileStore(encryptionKey: encryptionKey)
@@ -390,10 +376,6 @@ final class AppDelegate: NSObject, NSApplicationDelegate {
 
         remoteMessagingClient?.startRefreshingRemoteMessages()
 
-        if didCrashDuringCrashHandlersSetUp {
-            PixelKit.fire(GeneralPixel.crashOnCrashHandlersSetUp)
-            didCrashDuringCrashHandlersSetUp = false
-        }
     }
 
     private func fireFailedCompilationsPixelIfNeeded() {

diff --git a/LocalPackages/DataBrokerProtection/Package.swift b/LocalPackages/DataBrokerProtection/Package.swift
@@ -29,7 +29,7 @@ let package = Package(
             targets: ["DataBrokerProtection"])
     ],
     dependencies: [
-        .package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "171.1.1-1"),
+        .package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "171.1.1-2"),
         .package(path: "../SwiftUIExtensions"),
         .package(path: "../XPCHelper"),
     ],

diff --git a/LocalPackages/NetworkProtectionMac/Package.swift b/LocalPackages/NetworkProtectionMac/Package.swift
@@ -32,7 +32,7 @@ let package = Package(
         .library(name: "VPNAppLauncher", targets: ["VPNAppLauncher"]),
     ],
     dependencies: [
-        .package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "171.1.1-1"),
+        .package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "171.1.1-2"),
         .package(url: "https://github.com/airbnb/lottie-spm", exact: "4.4.3"),
         .package(path: "../AppLauncher"),
         .package(path: "../UDSHelper"),

diff --git a/LocalPackages/SubscriptionUI/Package.swift b/LocalPackages/SubscriptionUI/Package.swift
@@ -12,7 +12,7 @@ let package = Package(
             targets: ["SubscriptionUI"]),
     ],
     dependencies: [
-        .package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "171.1.1-1"),
+        .package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "171.1.1-2"),
         .package(path: "../SwiftUIExtensions")
     ],
     targets: [