Skip to content

Commit

Permalink
Rolls back cancelled pixel from internal hotfix
Browse files Browse the repository at this point in the history
  • Loading branch information
diegoreymendez committed Apr 29, 2024
1 parent 1f1b5f3 commit 040d73d
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ enum NetworkProtectionPixelEvent: PixelKitEventV2 {

case networkProtectionControllerStartAttempt
case networkProtectionControllerStartSuccess
case networkProtectionControllerStartCancelled
case networkProtectionControllerStartFailure(_ error: Error)

case networkProtectionTunnelStartAttempt
Expand Down Expand Up @@ -123,9 +122,6 @@ enum NetworkProtectionPixelEvent: PixelKitEventV2 {
case .networkProtectionControllerStartSuccess:
return "netp_controller_start_success"

case .networkProtectionControllerStartCancelled:
return "netp_controller_start_cancelled"

case .networkProtectionControllerStartFailure:
return "netp_controller_start_failure"

Expand Down Expand Up @@ -348,7 +344,6 @@ enum NetworkProtectionPixelEvent: PixelKitEventV2 {
.networkProtectionNewUser,
.networkProtectionControllerStartAttempt,
.networkProtectionControllerStartSuccess,
.networkProtectionControllerStartCancelled,
.networkProtectionControllerStartFailure,
.networkProtectionTunnelStartAttempt,
.networkProtectionTunnelStartSuccess,
Expand Down Expand Up @@ -420,7 +415,6 @@ enum NetworkProtectionPixelEvent: PixelKitEventV2 {
.networkProtectionNewUser,
.networkProtectionControllerStartAttempt,
.networkProtectionControllerStartSuccess,
.networkProtectionControllerStartCancelled,
.networkProtectionTunnelStartAttempt,
.networkProtectionTunnelStartSuccess,
.networkProtectionTunnelStopAttempt,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -564,7 +564,7 @@ final class NetworkProtectionTunnelController: TunnelController, TunnelSessionPr

if case StartError.cancelled = error {
PixelKit.fire(
NetworkProtectionPixelEvent.networkProtectionControllerStartCancelled, frequency: .dailyAndCount, includeAppVersionParameter: true
NetworkProtectionPixelEvent.networkProtectionControllerStartSuccess, frequency: .dailyAndCount, includeAppVersionParameter: true
)
} else {
PixelKit.fire(
Expand Down

0 comments on commit 040d73d

Please sign in to comment.