Malware protection 6: Malware integration #14665
Triggered via pull request
December 10, 2024 15:08
Status
Success
Total duration
13m 31s
Artifacts
–
pr.yml
on: pull_request
Matrix: Test
SwiftLint
44s
Test Shell Scripts
19s
Make Release Build
8m 32s
Verify autoconsent bundle
34s
ShellCheck
35s
Annotations
2 errors, 36 warnings, and 1 notice
Test (Non-Sandbox):
IntegrationTests/NavigationProtection/NavigationProtectionIntegrationTests.swift#L273
testGPC, XCTAssertEqual failed: ("[Integration_Tests.(unknown context at $102c20c40).Results.Result(id: "top frame header", value: Optional(Integration_Tests.(unknown context at $102c20c40).Results.Result.Value.string("1"))), Integration_Tests.(unknown context at $102c20c40).Results.Result(id: "top frame JS API", value: Optional(Integration_Tests.(unknown context at $102c20c40).Results.Result.Value.null)), Integration_Tests.(unknown context at $102c20c40).Results.Result(id: "frame header", value: nil), Integration_Tests.(unknown context at $102c20c40).Results.Result(id: "frame JS API", value: nil), Integration_Tests.(unknown context at $102c20c40).Results.Result(id: "subequest header", value: nil)]") is not equal to ("[Integration_Tests.(unknown context at $102c20c40).Results.Result(id: "top frame header", value: Optional(Integration_Tests.(unknown context at $102c20c40).Results.Result.Value.string("1"))), Integration_Tests.(unknown context at $102c20c40).Results.Result(id: "top frame JS API", value: Optional(Integration_Tests.(unknown context at $102c20c40).Results.Result.Value.null)), Integration_Tests.(unknown context at $102c20c40).Results.Result(id: "frame header", value: nil), Integration_Tests.(unknown context at $102c20c40).Results.Result(id: "frame JS API", value: Optional(Integration_Tests.(unknown context at $102c20c40).Results.Result.Value.bool(false))), Integration_Tests.(unknown context at $102c20c40).Results.Result(id: "subequest header", value: nil)]")
|
Test (Sandbox):
IntegrationTests/NavigationProtection/NavigationProtectionIntegrationTests.swift#L273
testGPC, XCTAssertEqual failed: ("[Integration_Tests_App_Store.(unknown context at $102c494c4).Results.Result(id: "top frame header", value: Optional(Integration_Tests_App_Store.(unknown context at $102c494c4).Results.Result.Value.string("1"))), Integration_Tests_App_Store.(unknown context at $102c494c4).Results.Result(id: "top frame JS API", value: Optional(Integration_Tests_App_Store.(unknown context at $102c494c4).Results.Result.Value.null)), Integration_Tests_App_Store.(unknown context at $102c494c4).Results.Result(id: "frame header", value: nil), Integration_Tests_App_Store.(unknown context at $102c494c4).Results.Result(id: "frame JS API", value: nil), Integration_Tests_App_Store.(unknown context at $102c494c4).Results.Result(id: "subequest header", value: nil)]") is not equal to ("[Integration_Tests_App_Store.(unknown context at $102c494c4).Results.Result(id: "top frame header", value: Optional(Integration_Tests_App_Store.(unknown context at $102c494c4).Results.Result.Value.string("1"))), Integration_Tests_App_Store.(unknown context at $102c494c4).Results.Result(id: "top frame JS API", value: Optional(Integration_Tests_App_Store.(unknown context at $102c494c4).Results.Result.Value.null)), Integration_Tests_App_Store.(unknown context at $102c494c4).Results.Result(id: "frame header", value: nil), Integration_Tests_App_Store.(unknown context at $102c494c4).Results.Result(id: "frame JS API", value: Optional(Integration_Tests_App_Store.(unknown context at $102c494c4).Results.Result.Value.bool(false))), Integration_Tests_App_Store.(unknown context at $102c494c4).Results.Result(id: "subequest header", value: nil)]")
|
ShellCheck
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
Verify autoconsent bundle
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
SwiftLint
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
Make Release Build:
LocalPackages/XPCHelper/Sources/XPCHelper/XPCServer.swift#L56
capture of 'newConnection' with non-sendable type 'NSXPCConnection' in a `@Sendable` closure; this is an error in the Swift 6 language mode
|
Make Release Build:
LocalPackages/XPCHelper/Sources/XPCHelper/XPCServer.swift#L56
capture of 'newConnection' with non-sendable type 'NSXPCConnection' in a `@Sendable` closure; this is an error in the Swift 6 language mode
|
Make Release Build:
LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
|
Make Release Build:
LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
|
Make Release Build:
LocalPackages/AppKitExtensions/Sources/AppKitExtensions/NSEventExtension.swift#L118
extension declares a conformance of imported type 'Set' to imported protocols 'ExpressibleByStringLiteral', 'ExpressibleByExtendedGraphemeClusterLiteral', 'ExpressibleByUnicodeScalarLiteral'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
|
Make Release Build:
LocalPackages/AppKitExtensions/Sources/AppKitExtensions/NSEventExtension.swift#L118
extension declares a conformance of imported type 'Set' to imported protocols 'ExpressibleByStringLiteral', 'ExpressibleByExtendedGraphemeClusterLiteral', 'ExpressibleByUnicodeScalarLiteral'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
|
Make Release Build:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L179
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Make Release Build:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L173
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Make Release Build:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L326
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Make Release Build:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L322
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Test (Non-Sandbox)
sandbox-test-tool isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'sandbox-test-tool' from project 'DuckDuckGo')
|
Test (Non-Sandbox):
LocalPackages/XPCHelper/Sources/XPCHelper/XPCServer.swift#L56
capture of 'newConnection' with non-sendable type 'NSXPCConnection' in a `@Sendable` closure; this is an error in the Swift 6 language mode
|
Test (Non-Sandbox):
LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
|
Test (Non-Sandbox):
LocalPackages/AppKitExtensions/Sources/AppKitExtensions/NSEventExtension.swift#L118
extension declares a conformance of imported type 'Set' to imported protocols 'ExpressibleByStringLiteral', 'ExpressibleByExtendedGraphemeClusterLiteral', 'ExpressibleByUnicodeScalarLiteral'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
|
Test (Non-Sandbox):
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L179
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Test (Non-Sandbox):
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L173
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Test (Non-Sandbox):
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L326
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Test (Non-Sandbox):
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L322
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Test (Non-Sandbox):
LocalPackages/SubscriptionUI/Sources/SubscriptionUI/DebugMenu/DebugPurchaseView.swift#L167
extension declares a conformance of imported type 'String' to imported protocol 'Identifiable'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
|
Test (Non-Sandbox):
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/NetworkProtectionTokenStore+SubscriptionTokenKeychainStorage.swift#L25
extension declares a conformance of imported type 'NetworkProtectionKeychainTokenStore' to imported protocol 'SubscriptionTokenStoring'; this will not behave correctly if the owners of 'NetworkProtection' introduce this conformance in the future
|
Test (Non-Sandbox):
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L135
'VPNLogger' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
Test (Sandbox)
sandbox-test-tool isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'sandbox-test-tool' from project 'DuckDuckGo')
|
Test (Sandbox):
LocalPackages/XPCHelper/Sources/XPCHelper/XPCServer.swift#L56
capture of 'newConnection' with non-sendable type 'NSXPCConnection' in a `@Sendable` closure; this is an error in the Swift 6 language mode
|
Test (Sandbox):
LocalPackages/XPCHelper/Sources/XPCHelper/XPCServer.swift#L56
capture of 'newConnection' with non-sendable type 'NSXPCConnection' in a `@Sendable` closure; this is an error in the Swift 6 language mode
|
Test (Sandbox):
LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
|
Test (Sandbox):
LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
|
Test (Sandbox):
LocalPackages/AppKitExtensions/Sources/AppKitExtensions/NSEventExtension.swift#L118
extension declares a conformance of imported type 'Set' to imported protocols 'ExpressibleByStringLiteral', 'ExpressibleByExtendedGraphemeClusterLiteral', 'ExpressibleByUnicodeScalarLiteral'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
|
Test (Sandbox):
LocalPackages/AppKitExtensions/Sources/AppKitExtensions/NSEventExtension.swift#L118
extension declares a conformance of imported type 'Set' to imported protocols 'ExpressibleByStringLiteral', 'ExpressibleByExtendedGraphemeClusterLiteral', 'ExpressibleByUnicodeScalarLiteral'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
|
Test (Sandbox):
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L179
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Test (Sandbox):
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L173
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Test (Sandbox):
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L326
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Test (Sandbox):
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L322
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Private API Report / Update PR comment
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
Test (Sandbox)
Skipped Integration_Tests_App_Store.DownloadsIntegrationTests.testWhenLocalFile_downloadStartsAlwaysDisplayingSavePanel
|