better guards on access tab index #3821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dus7
approved these changes
Jan 17, 2025
| @@ -75,7 +75,7 @@ public class TabsModel: NSObject, NSCoding { | |||
|
|
|||
| var currentTab: Tab? { | |||
| let index = currentIndex | |||
| return tabs[index] | |||
| return tabs.indices.contains(index) ? tabs[index] : nil | |||
There was a problem hiding this comment.
There's also an extension with safe subscript for RandomAccessCollection in BSK, but that will work just fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/392891325557410/1209158320724215/f
Tech Design URL:
CC:
Description:
Speculative fix for a crash. Checks index is available in indices before accessing the array.
Steps to test this PR:
Smoke test tab manager on iPhone and iPad