Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tds override #3805

Merged
merged 12 commits into from
Jan 17, 2025
Merged

tds override #3805

merged 12 commits into from
Jan 17, 2025

Conversation

SabrinaTardio
Copy link
Contributor

@SabrinaTardio SabrinaTardio commented Jan 15, 2025

Task/Issue URL: https://app.asana.com/0/72649045549333/1209114783599181/f
Tech Design URL: https://app.asana.com/0/481882893211075/1208547600159199
CC:

Description: Makes the tds fetch dependent on the privacy configuration fetch (so that the url for tds can be taken from the configuration). Sets up experiment for tds. Note metrics will be added in a separate PR.

Steps to test this PR:

  1. Run the Application
  2. On the debugger filter for "Stored etag for trackerDataSet" and write down the etag
  3. Go to Settings -> All debug Options -> Configuration URLs
  4. Click on privacy config and use this URL: ### https://staticcdn.duckduckgo.com/trackerblocking/config/test/macos-config.json
  5. On the debugger filter for "Stored etag for trackerDataSet" and check the etag is now 2ce60c57c3d384f986ccbe2c422aac44
  6. Check also that "CBR compilation for TrackerDataSet succeeded" has been logged
  7. Check “experiment_enroll_tdsNextExperimentBaseline_treatment” has been sent
  8. Click on privacy config and reset to default URL
  9. On the debugger filter for "Stored etag for trackerDataSet" and check the etag has gone back to previous one (382541021cbc55b218714db779561a51)
  10. Check also that "CBR compilation for TrackerDataSet succeeded" has been logged

<!—
Before submitting a PR, please ensure you have tested the combinations you expect the reviewer to test, then delete configurations you know do not need explicit testing.

Using a simulator where a physical device is unavailable is acceptable.
—>

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@SabrinaTardio SabrinaTardio changed the title Sabrina/tds override tds override Jan 15, 2025
@SabrinaTardio SabrinaTardio marked this pull request as ready for review January 15, 2025 10:59
SabrinaTardio added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Jan 17, 2025
@SabrinaTardio SabrinaTardio merged commit c66aea0 into main Jan 17, 2025
13 checks passed
@SabrinaTardio SabrinaTardio deleted the sabrina/tds-override branch January 17, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants