-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tds override #3805
Merged
Merged
tds override #3805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
bwaresiak
reviewed
Jan 16, 2025
bwaresiak
reviewed
Jan 16, 2025
bwaresiak
reviewed
Jan 17, 2025
bwaresiak
approved these changes
Jan 17, 2025
SabrinaTardio
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Jan 17, 2025
Task/Issue URL: https://app.asana.com/0/72649045549333/1209114783599181/f iOS PR: duckduckgo/iOS#3805 macOS PR: duckduckgo/macos-browser#3726 What kind of version bump will this require?: Major
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1209114783599181/f
Tech Design URL: https://app.asana.com/0/481882893211075/1208547600159199
CC:
Description: Makes the tds fetch dependent on the privacy configuration fetch (so that the url for tds can be taken from the configuration). Sets up experiment for tds. Note metrics will be added in a separate PR.
Steps to test this PR:
<!—
Before submitting a PR, please ensure you have tested the combinations you expect the reviewer to test, then delete configurations you know do not need explicit testing.
Using a simulator where a physical device is unavailable is acceptable.
—>
Definition of Done (Internal Only):
Copy Testing:
’
rather than’
Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
—
Internal references:
Software Engineering Expectations
Technical Design Template