Remove data inconsistency reporting pixels #3795
Merged
+6
−166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dus7
commented
Jan 13, 2025
| } else { | ||
| return await fetcherStorage.wasAttributionReportSuccessful | ||
| } | ||
| return await !fetcherStorage.wasAttributionReportSuccessful |
There was a problem hiding this comment.
There was a mistake in previous PR - there was no negation (https://github.com/duckduckgo/iOS/pull/3510/files#diff-6fd446bd1dcbca6190f5371b19e0abc7568e824facf0aac081c01e84e034fbcfR44), but assuming attributionReportSuccessfulFileMarker was present at all times it probably wasn't an issue.
dus7
requested review from
a team,
mallexxx and
diegoreymendez
and removed request for
a team and
mallexxx
diegoreymendez
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1205278999335242/1208659901469299/f
Tech Design URL:
CC:
Description:
Removes temporary pixels used for monitoring UserDefaults data inconsistencies.
Steps to test this PR:
Definition of Done (Internal Only):
Copy Testing:
’rather than'Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template