Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Malicious site protection navigation detection integration #3730

Open
wants to merge 14 commits into
base: alessandro/malicious-site-protection
Choose a base branch
from

Conversation

alessandroboron
Copy link
Contributor

@alessandroboron alessandroboron commented Dec 16, 2024

Task/Issue URL: https://app.asana.com/0/72649045549333/1208758247571054/f
CC: @not-a-rootkit

Description:

Integrate BSK library for malicious threat detection.

Steps to test this PR:

Prerequisites: Return true in MaliciousSiteProtectionFeatureFlags.swift -> isMaliciousSiteProtectionEnabled and shouldDetectMaliciousThreat(forDomain domain: String?) -> Bool

Scenario 1 - Phishing

  1. Navigate to http://privacy-test-pages.site/security/badware/phishing.html
  2. Ensure special error pages is shown.

Scenario 2 - Malware

  1. Navigate to http://privacy-test-pages.site/security/badware/malware.html
  2. Ensure special error pages is shown.

Scenario 3 - Leave Site Creates an Empty Tab at same index of the tab closed

  1. Open multiple tabs and load some random websites
  2. Open a tab and load a malicious website.
  3. When the special error page is shown, tap the “Leave Site” Button.
  4. Ensure that when the Tab is closed a new empty one is created at the same index.

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

Copy link

github-actions bot commented Dec 16, 2024

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS against 91622ac

@alessandroboron alessandroboron force-pushed the alessandro/malicious-site-protection-navigation-detection-integration branch 4 times, most recently from 2096a74 to 0838920 Compare December 16, 2024 16:07
import Foundation
import MaliciousSiteProtection
import Networking
import PixelKit

final class MaliciousSiteProtectionManager: MaliciousSiteDetecting {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alessandroboron alessandroboron changed the title Alessandro/malicious site protection navigation detection integration Malicious site protection navigation detection integration Dec 16, 2024
@alessandroboron alessandroboron force-pushed the alessandro/malicious-site-protection-feature-flags branch from a41d843 to 99e6543 Compare December 19, 2024 12:48
@alessandroboron alessandroboron force-pushed the alessandro/malicious-site-protection-navigation-detection-integration branch from ed4e32b to b5fe830 Compare December 19, 2024 12:49
Copy link

This PR has been inactive for more than 7 days and will be automatically closed 7 days from now.

@github-actions github-actions bot added the stale label Dec 27, 2024
Copy link

github-actions bot commented Jan 4, 2025

This PR has been closed after 14 days of inactivity. Feel free to reopen it if you plan to continue working on it or have further discussions.

@github-actions github-actions bot closed this Jan 4, 2025
@alessandroboron alessandroboron force-pushed the alessandro/malicious-site-protection-feature-flags branch from 99e6543 to a76c78f Compare January 9, 2025 02:42
@alessandroboron alessandroboron force-pushed the alessandro/malicious-site-protection-navigation-detection-integration branch from b5fe830 to 29703ba Compare January 9, 2025 02:49
@alessandroboron alessandroboron force-pushed the alessandro/malicious-site-protection-feature-flags branch from a76c78f to 560ef30 Compare January 9, 2025 04:29
@alessandroboron alessandroboron force-pushed the alessandro/malicious-site-protection-navigation-detection-integration branch 3 times, most recently from 966f6cc to 4d87dab Compare January 10, 2025 07:25
@alessandroboron alessandroboron force-pushed the alessandro/malicious-site-protection-feature-flags branch from 744d6aa to e791a06 Compare January 14, 2025 03:43
Base automatically changed from alessandro/malicious-site-protection-feature-flags to alessandro/malicious-site-protection January 14, 2025 03:53
@alessandroboron alessandroboron force-pushed the alessandro/malicious-site-protection-navigation-detection-integration branch from 4d87dab to 91622ac Compare January 14, 2025 07:49
@alessandroboron alessandroboron removed the request for review from jaceklyp January 15, 2025 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant