Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fire tab switcher / manager sources pixel #3722

Merged
merged 8 commits into from
Dec 13, 2024
Merged

Conversation

brindy
Copy link
Contributor

@brindy brindy commented Dec 12, 2024

Task/Issue URL: https://app.asana.com/0/392891325557410/1208882840835128/f
Tech Design URL:
CC:

Description:
Fires a pixel depending on what is going on when the user opens the tab switcher.

Also renames a couple of pixels for clarity.

Steps to test this PR:

  1. Open the tab switcher from anywhere should fire m_tab_manager_opened_daily but only the first time during in a day
  2. Open the tab switcher from anywhere should fire m_tab_manager_opened every time
  3. Open the tab switcher on the new tab page should fire m_tab_manager_open_from_newtabpage every time
  4. Open the tab switcher while on the serp should fire m_tab_manager_open_from_serp every time
  5. Open the tab switcher while on a website should fire m_tab_manager_open_from_website every time

@brindy brindy requested a review from Bunn December 12, 2024 13:10
Copy link
Contributor

@Bunn Bunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed yesterday. Forgot to mark as done, my bad. LGTM

@brindy brindy merged commit 4d78d09 into main Dec 13, 2024
16 checks passed
@brindy brindy deleted the brindy/tab-switch-source branch December 13, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants