Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ship review feedback - Color + Orientation #3715

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Ship review feedback - Color + Orientation #3715

merged 3 commits into from
Dec 11, 2024

Conversation

Bunn
Copy link
Contributor

@Bunn Bunn commented Dec 11, 2024

Task/Issue URL: https://app.asana.com/0/1204167627774280/1208947094200047/f

Description:
Remove landscape mode for iPhone
Change the background color for the AI Chat webview

Steps to test this PR:

  1. Check if you can open AI Chat in landscape mode on iPhone you shouldn't.
  2. Check if the background color for the webview matches the one in the AI Chat itself. Task

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 11, 2024 •
edited
Loading

Fails
🚫 DesignResourcesKit: No new colors should be added to this app.

Generated by 🚫 dangerJS against a0d2307

@brindy brindy self-requested a review December 11, 2024 14:14
brindy
brindy approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - can ignore the danger message as this is specific to AI Chat and we'll be updating the app design in the future anyway.

@Bunn Bunn merged commit 7273be8 into release/7.149.0 Dec 11, 2024
12 of 13 checks passed
@Bunn Bunn deleted the bunn/aichat/ship-review-feedback branch December 11, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brindy brindy brindy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bunn @brindy