Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add required app groups to all entitlements #3703

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Add required app groups to all entitlements #3703

merged 2 commits into from
Dec 10, 2024

Conversation

amddg44
Copy link
Contributor

@amddg44 amddg44 commented Dec 10, 2024 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/72649045549333/1207512172220035/f
Tech Design URL:
CC:

Description:
Update entitlements for vault app group

Steps to test this PR:

  1. In XCode confirm App Groups and Keychain Sharing contain the vault group for the debug and release configurations
image
Internal references:

Software Engineering Expectations
Technical Design Template

@amddg44 amddg44 requested review from aataraxiaa and graeme December 10, 2024 08:22
graeme
graeme approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@graeme graeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@amddg44 amddg44 merged commit bd72723 into main Dec 10, 2024
27 of 29 checks passed
@amddg44 amddg44 deleted the anya/cred-provider-release-config branch December 10, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graeme graeme graeme approved these changes

@aataraxiaa aataraxiaa Awaiting requested review from aataraxiaa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amddg44 @graeme