Update Privacy Pro translations #3700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…port proper localisation
|
samsymons
reviewed
Dec 10, 2024
Comment on lines
1083
to
1080
| "duckplayer.presentation.modal.body" = "Duck Player giver dig mulighed for at se YouTube uden målrettede annoncer i en biograflignende oplevelse i DuckDuckGo, og det, du ser, påvirker ikke dine anbefalinger."; | ||
| "duckplayer.presentation.modal.body" = "Duck Player lets you watch YouTube without targeted ads in DuckDuckGo and what you watch won’t influence your recommendations."; |
There was a problem hiding this comment.
This change seems incorrect?
There was a problem hiding this comment.
This was one of two excluded duckplayer strings and apparently it also changed the value. Removed exclusion and re-imported the strings, should be fine now.
samsymons
reviewed
Dec 10, 2024
| "duckplayer.settings.info-text" = "Duck Player giver en ren seeroplevelse uden målrettede annoncer og forhindrer, at visningsaktivitet påvirker dine YouTube-anbefalinger."; | ||
| "duckplayer.settings.info-text" = "Duck Player lets you watch YouTube without targeted ads in DuckDuckGo and what you watch won’t influence your recommendations."; |
There was a problem hiding this comment.
This one looks incorrect too.
samsymons
reviewed
Dec 10, 2024
Comment on lines
-1535
to
-1536
| /* No comment provided by engineer. */ | ||
| "LOREM IPSUM" = "LOREM IPSUM"; |
samsymons
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1208750072186506/f
CC: @bwaresiak
Description:
Update Privacy Pro and VPN related translations.
Steps to test this PR:
Change preferred language for the app and verify completeness for:
Definition of Done (Internal Only):
Copy Testing:
’rather than'Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template