Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fake experiment #3688

Merged
merged 3 commits into from
Dec 6, 2024
Merged

add fake experiment #3688

merged 3 commits into from
Dec 6, 2024

Conversation

SabrinaTardio
Copy link
Contributor

@SabrinaTardio SabrinaTardio commented Dec 6, 2024

Task/Issue URL: https://app.asana.com/0/72649045549333/1208905776162821/f
Tech Design URL:
CC:

Description: Used Fake Test feature to generate a cohort and do and A/A test run of the New experiment framework. We want to make sure cohort is assigned and pixels are fired as expected.

Steps to test this PR:

  1. If the configuration is not live yet please use https://www.jsonblob.com/api/jsonBlob/1314517780330110976 as config link
  2. Run the app
  3. Check 👾[Unique By Name And Parameters-Fired] experiment_enroll_experimentTestAA_treatment_ios_phone ["pixelSource": "phone", "enrollmentDate": "2024-12-06”] is sent (with either treatment or control in the name)

<!—
Before submitting a PR, please ensure you have tested the combinations you expect the reviewer to test, then delete configurations you know do not need explicit testing.

Using a simulator where a physical device is unavailable is acceptable.
—>

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@SabrinaTardio SabrinaTardio marked this pull request as ready for review December 6, 2024 09:40
@SabrinaTardio SabrinaTardio requested a review from ayoy December 6, 2024 09:43
@SabrinaTardio SabrinaTardio changed the title add test experiment and start it add fake experiment Dec 6, 2024
Copy link
Contributor

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flawless 💪

SabrinaTardio added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Dec 6, 2024
**Required**:

Task/Issue URL:
https://app.asana.com/0/72649045549333/1208905776162821/f
iOS PR: duckduckgo/iOS#3688
macOS PR: duckduckgo/macos-browser#3637
What kind of version bump will this require?: Patch

**Description**: Adds Fake Test feature to do and A/A test run of the
New experiment framework. We want to make sure cohort is assigned and
pixels are fired as expected.
@SabrinaTardio SabrinaTardio merged commit 5880851 into main Dec 6, 2024
13 checks passed
@SabrinaTardio SabrinaTardio deleted the sabrina/setup-experiment-test branch December 6, 2024 17:22
samsymons added a commit that referenced this pull request Dec 6, 2024
…ild-number

# By Alessandro Boron (1) and Sabrina Tardio (1)
# Via GitHub
* main:
  add fake experiment (#3688)
  Alessandro/onboarding add to dock experiment setup (#3679)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants