Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Privacy Pro translations #3681

Closed
wants to merge 6 commits into from

Conversation

miasma13
Copy link
Contributor

@miasma13 miasma13 commented Dec 5, 2024

Task/Issue URL: https://app.asana.com/0/0/1208750072186506/f

Description:
Update Privacy Pro and VPN related translations.

Steps to test this PR:
Change preferred language for the app and verify completeness for:

  • Privacy Pro settings when not signed in
  • Privacy Pro settings when signed in
  • VPN settings and popover views

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

Copy link

github-actions bot commented Dec 5, 2024

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.
Messages
📖

You seem to be updating localized strings. Make sure that you request translations and include translated strings before you ship your change. See Localization Guidelines for more information.

Generated by 🚫 dangerJS against 76895ed

@bwaresiak bwaresiak deleted the branch release/7.148.0 December 9, 2024 13:01
@bwaresiak bwaresiak closed this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants