Alessandro/onboarding add to dock experiment setup #3679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessandroboron
changed the base branch from
alessandro/onboarding-add-to-dock-ship-review
to
alessandro/onboarding-add-to-dock-clean-up-old-code
Task/Issue URL: https://app.asana.com/0/1206329551987282/1208258905717852/f **Description**: This PR removes the onboarding experiment branches and sets the onboarding highlights and contextual dialogs for all the users.
Base automatically changed from
alessandro/onboarding-add-to-dock-clean-up-old-code
to
alessandro/onboarding-add-to-dock-ship-review
December 5, 2024 16:39
SabrinaTardio
approved these changes
Dec 5, 2024
Comment on lines
+44
to
+49
| .onReceive(NotificationCenter.default.publisher(for: UIApplication.didEnterBackgroundNotification), perform: { _ in | ||
| isPlaying.wrappedValue = false | ||
| }) | ||
| .onReceive(NotificationCenter.default.publisher(for: UIApplication.didBecomeActiveNotification)) { _ in | ||
| isPlaying.wrappedValue = true | ||
| } |
…foreground after backgrounding it
alessandroboron
force-pushed
the
alessandro/onboarding-add-to-dock-experiment-setup
branch
from
0d135e6 to
c8d2e97
Compare
alessandroboron
changed the base branch from
alessandro/onboarding-add-to-dock-ship-review
to
main
|
|
@SabrinaTardio as per our discussion instead of opening another PR I followed your advice and changed the main target branch to be main |
alessandroboron
deleted the
alessandro/onboarding-add-to-dock-experiment-setup
branch
samsymons
added a commit
that referenced
this pull request
Dec 6, 2024
…ild-number # By Alessandro Boron (1) and Sabrina Tardio (1) # Via GitHub * main: add fake experiment (#3688) Alessandro/onboarding add to dock experiment setup (#3679) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1206329551987282/1208662187851716/f
Description:
This PR setup the Add to Dock experiment to be prompted from the onboarding flow.
The commits are self-contained. The PR includes a small cleanup of unused onboarding variables (last commit). You can review that one separately to avoid polluting the overall review
Steps to test this PR:
Scenario 1 - Present Add to Dock from linear onboarding
return VariantIOS(name: "mk", weight: 1, isIncluded: VariantIOS.When.notPadDevice, features: [.addToDockIntro])inDefaultVariantManager->selectVariant() -> Variant?at line 155.return trueinHomeRowReminder->func showNow() -> Boolat line 55 (after the variant check)Scenario 2 - Add to Dock is presented from contextual onboarding
return VariantIOS(name: "mo", weight: 1, isIncluded: VariantIOS.When.notPadDevice, features: [.addToDockContextual])inDefaultVariantManager->selectVariant() -> Variant?at line 155.return trueinHomeRowReminder->func showNow() -> Boolat line 55 (after the variant check)Scenario 3 - Add To Dock is presented from banner for control variant
return VariantIOS(name: "mh", weight: 1, isIncluded: VariantIOS.When.notPadDevice, features: [])inDefaultVariantManager->selectVariant() -> Variant?at line 155.return trueinHomeRowReminder->func showNow() -> Boolat line 55 (after the variant check)return true)Scenario 4 - Smoke test pixels are sent
Link to the Pixel scenarios #3543
Definition of Done (Internal Only):
Copy Testing:
’rather than'Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template