Credential provider extension with credential list support #3658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er' into anya/credential-provider-extension # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
…er' into anya/credential-provider-extension # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
…ersion and adding vault to the entitlement groups
…tate, authentication handling
6 tasks
…er' into anya/credential-provider-extension # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
aataraxiaa
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Overall looks great, @amddg44, left a few minor comments. Also tested and works as expected.
| guard let cacheUrl = FaviconsCacheType.fireproof.cacheLocation() else { return nil } | ||
|
|
||
| // Slight leap here to avoid loading Kingisher as a library for the widgets. | ||
| // Once dependency management is fixed, link it and use Favicons directly. |
Comment on lines
124
to
127
| guard let domain = domain else { return nil } | ||
|
|
||
| let key = FaviconHasher.createHash(ofDomain: domain) | ||
| guard let cacheUrl = FaviconsCacheType.fireproof.cacheLocation() else { return nil } |
There was a problem hiding this comment.
Minor: Maybe could slightly restructure this as:
guard let domain = domain,
let cacheUrl = FaviconsCacheType.fireproof.cacheLocation() else {
return nil
}
Just putting the two guards at the beginning.
| import Core | ||
| import SwiftUI | ||
|
|
||
| class CredentialProviderListViewController: UIViewController { |
There was a problem hiding this comment.
Minor: Can prob make final
| import BrowserServicesKit | ||
| import Core | ||
|
|
||
| class CredentialProviderViewController: ASCredentialProviderViewController { |
There was a problem hiding this comment.
Minor: Can prob make final
| extension UIResponder { | ||
|
|
||
| @discardableResult | ||
| func openUrl(_ url: URL?) -> Bool { |
There was a problem hiding this comment.
I think a small bit of documentation here explaining this would be helpful
amddg44
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Dec 7, 2024
Task/Issue URL: iOS PR: duckduckgo/iOS#3658 macOS PR: duckduckgo/macos-browser#3628 What kind of version bump will this require?: Minor **Description**: Migrates secure vault DB file to shared storage, and migrates the vault keychain items to shared keychain on iOS for usage by its new credential provider extension
amddg44
merged commit 611e9dc
into
feature/system-credential-provider
12 of 13 checks passed
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL:
Tech Design URL:
CC:
Description:
Adds the Credential provider extension to the app, with functionality to view all + select from saved passwords for autofilling in 3rd party apps.
Steps to test this PR:
Note: Use the Alpha target for testing, as the extension has not been enabled on the main app target yet.
<!—
Before submitting a PR, please ensure you have tested the combinations you expect the reviewer to test, then delete configurations you know do not need explicit testing.
Using a simulator where a physical device is unavailable is acceptable.
—>
Definition of Done (Internal Only):
Copy Testing:
’rather than’Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
—
Internal references:
Software Engineering Expectations
Technical Design Template