Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code comment for extra attributes added for PPro campaign #3641

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

quanganhdo
Copy link
Member

Task/Issue URL: https://app.asana.com/0/488551667048375/1208863264197081/f
Tech Design URL:
CC:

Description:

Adds some comments.

Steps to test this PR:

  1. CI passes

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@quanganhdo quanganhdo requested a review from dus7 November 28, 2024 15:01
@quanganhdo quanganhdo merged commit a606343 into main Nov 28, 2024
16 checks passed
@quanganhdo quanganhdo deleted the anh/ppro/comments branch November 28, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants