Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include inactive tabs statistics in daily tab switcher pixel #3633

Closed
wants to merge 3 commits into from

Conversation

dus7
Copy link
Contributor

@dus7 dus7 commented Nov 27, 2024

Task/Issue URL: https://app.asana.com/0/72649045549333/1208778471392233/f
Tech Design URL:
CC:

Description:

Adds statistics information about inactive tabs to m_tab_manager_clicked_daily pixel. Although Tab model has been changed, migration is not necessary. New property is optional and is defaulting to nil in case no value has been found.
Pixel details can be found in this task.

Steps to test this PR:

Prerequisite: Change DailyPixel.hasBeenFiredToday to return false.

  1. Build and run current public version (can be any recent one) or make sure you already have a few tabs opened.
  2. Build and run this code.
  3. Observe pixel after opening tab switcher:
    1. There should be 0 inactive tabs reported (as they don't have last activity date stored)
    2. Go to a few of opened tabs, on next pixel fire they should be counted as inactive tabs in respective bucket (tab_active_7d).
  4. Open a bunch of new tabs.
  5. Observe pixel parameters include new tabs in counts after opening tab switcher.

Definition of Done (Internal Only):


Internal references:

Software Engineering Expectations
Technical Design Template

@dus7 dus7 changed the title Mariusz/inactive tabs statistics Include inactive tabs statistics in daily tab switcher pixel Nov 27, 2024
@dus7 dus7 marked this pull request as draft November 27, 2024 17:21
@dus7 dus7 force-pushed the mariusz/inactive-tabs-statistics branch from 80f157c to 0120f33 Compare November 28, 2024 15:28
@dus7 dus7 closed this Nov 28, 2024
@dus7 dus7 deleted the mariusz/inactive-tabs-statistics branch November 29, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant