Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add launch time pixels #3621

Merged
merged 4 commits into from
Nov 26, 2024
Merged

Add launch time pixels #3621

merged 4 commits into from
Nov 26, 2024

Conversation

jaceklyp
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/0/1208832732122368/f

Description:
We want to measure our app’s launch speed to establish a baseline for future improvements.

Steps to test this PR:

  1. Launch the app and check if three m.debug.app-did-* pixels fired.
  2. Launch the app and quickly go into background - the pixel related to showing the UI likely shouldn’t be triggered.

@jaceklyp jaceklyp requested a review from bwaresiak November 26, 2024 09:36
bwaresiak
bwaresiak approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@bwaresiak bwaresiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jaceklyp jaceklyp changed the base branch from main to release/7.147.0 November 26, 2024 14:31
@jaceklyp jaceklyp merged commit 6eaa17e into release/7.147.0 Nov 26, 2024
18 checks passed
@jaceklyp jaceklyp deleted the jacek/launch-time-pixels branch November 26, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwaresiak bwaresiak bwaresiak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaceklyp @bwaresiak