Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump BSK to 211.1.1 #3609

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Bump BSK to 211.1.1 #3609

merged 1 commit into from
Nov 21, 2024

Conversation

ayoy
Copy link
Contributor

@ayoy ayoy commented Nov 21, 2024

Task/Issue URL: https://app.asana.com/0/414235014887631/1208817367615044/f

Description:
This bumps BSK dependency to the latest version including 211.0.0-1 hotfix.

Steps to test this PR:
Verify that CI is green

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@ayoy ayoy requested a review from samsymons November 21, 2024 17:27
@ayoy ayoy merged commit 5d78328 into main Nov 21, 2024
16 checks passed
@ayoy ayoy deleted the dominik/bsk-bump branch November 21, 2024 17:46
samsymons added a commit that referenced this pull request Nov 22, 2024
…g-error

# By Dominik Kapusta (3) and others
# Via Dominik Kapusta (1) and others
* main:
  Expand persistent pixel usage (#3596)
  Release 7.146.0-2 (#3610)
  Bump BSK to 211.1.1 (#3609)
  Update BSK with a C-S-S fix (#3608)
  remove widget favicon coupling and move favicon code from core to the app (#3590)
  Update Content Scope Scripts to 6.38.0 (#3605)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants