Prevent making Favicons network call in NewTabPageFavoritesModelTests #3607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dus7
changed the title
dus7
changed the title
dus7
changed the title
dus7
requested review from
bwaresiak,
a team and
tomasstrba
and removed request for
bwaresiak and
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1206226850447395/1208808876345674/f
Tech Design URL:
CC:
Description:
Favicons shared instance was used directly inside
FavoritesViewModelwhile runningNewTabPageFavoritesModelTests, which caused a real network call.This PR introduces local abstraction for Favicons cache access, to prevent calling the real implementation.
Steps to test this PR:
foo.bardomain.Definition of Done (Internal Only):
Internal references:
Software Engineering Expectations
Technical Design Template