remove widget favicon coupling and move favicon code from core to the app #3590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwaresiak
approved these changes
Nov 21, 2024
…le (#3593) Task/Issue URL: https://app.asana.com/0/392891325557410/1208796954308702/f Tech Design URL: CC: @bwaresiak **Description**: Rename preserved logins to fireproofing and use protocol where possible This is stacked on #3590 - am trying to make baby steps towards removing a few of the gnarlier singletons (Favicons and Fireproofing at least) **Steps to test this PR**: 1. Smoke test fireproofing with cookies, you can use https://www.setcookie.net (remember to set an expiry date for it to work) 2. Go into Settings > Data Clearing > Fireproof sites and make sure fire proofed sites are visible and can be deleted from there 3. Check it works and visible in the settings UI
|
samsymons
added a commit
that referenced
this pull request
Nov 22, 2024
…g-error # By Dominik Kapusta (3) and others # Via Dominik Kapusta (1) and others * main: Expand persistent pixel usage (#3596) Release 7.146.0-2 (#3610) Bump BSK to 211.1.1 (#3609) Update BSK with a C-S-S fix (#3608) remove widget favicon coupling and move favicon code from core to the app (#3590) Update Content Scope Scripts to 6.38.0 (#3605) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414709148257752/1208785980508806/f
Tech Design URL:
CC:
Description:
Moves the favicon code the app bundle to make future refactoring easier.
Includes refactoring from #3593
Steps to test this PR:
favicons tabs locationin Xcode console and go to the parent of that directory.favicons fireproof location