Add delay when shutting down VPN due to error #3579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
…g-error # By Mariusz Śpiewak (4) and others # Via GitHub (1) and Mariusz Śpiewak (1) * main: Re-prompt for crash reporting (#3595) Fix running BoolFileMarkerTest on device (#3601) Run Sync e2e tests only on latest version (#3602) Release 7.146.0-1 (#3600) Fix autofill search authentication looping (#3598) Fix invalid OmniBar state transition on loading (#3599) Update autoconsent to v11.5.0 (#3581) Release 7.146.0-0 (#3594) deps: Bump [email protected] and BSK@211 (#3588) Update subtitle (#3592) Limits TipKit availability to iOS 18+ (#3589) Fix alpha build compilation (#3584) Update VPN auth token check logic (#3585) Fix button shapes on New Tab Page (#3586) Temporarily disable TipKit (#3564) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
diegoreymendez
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
I tested this and it works as described. The new error messages look neat too.
Nice job @samsymons
samsymons
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Nov 22, 2024
…g an error (#1078) Required: Task/Issue URL: https://app.asana.com/0/1207603085593419/1208772807738114/f iOS PR: duckduckgo/iOS#3579 macOS PR: duckduckgo/macos-browser#3557 What kind of version bump will this require?: Patch Description: This PR adds a short delay when shutting down the tunnel.
…g-error # By Dominik Kapusta (3) and others # Via Dominik Kapusta (1) and others * main: Expand persistent pixel usage (#3596) Release 7.146.0-2 (#3610) Bump BSK to 211.1.1 (#3609) Update BSK with a C-S-S fix (#3608) remove widget favicon coupling and move favicon code from core to the app (#3590) Update Content Scope Scripts to 6.38.0 (#3605) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
deleted the
sam/delay-shutting-down-vpn-when-encountering-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1207603085593419/1208772807738114/f
Tech Design URL:
CC:
Description:
This PR adds a short delay before shutting down the VPN due to an error.
Steps to test this PR:
startTunnel(onDemand:)is a good place to do thisFiring persistent daily/count pixelDefinition of Done (Internal Only):
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template