[DuckPlayer] Overlay Usage Pixels #3565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement pixels for youtubeOverlay behavior
15 tasks
ankushkushwaha
approved these changes
Nov 13, 2024
Bunn
approved these changes
Nov 13, 2024
afterxleep
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Nov 14, 2024
Task/Issue URL: https://app.asana.com/0/1204099484721401/1208739766555303/f **Description**: - Adds temporary Overlay usage pixels - This uses the same approach we use on iOS: duckduckgo/iOS#3565
samsymons
added a commit
that referenced
this pull request
Nov 14, 2024
# By Daniel Bernal (3) and others # Via GitHub * main: Remove the `ld_classic` build setting (#3575) text zoom improvements (#3509) Add support for local overrides for feature flags (#3571) pixels for bookmarks > favorites tab (#3572) Sync BSK with macos (#3561) Add possibility to stop page loading (#3553) [DuckPlayer] Overlay Usage Pixels (#3565) Update pr.yml Update pr.yml # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1204099484721401/1208739766555300/f
Description:
Steps to test this PR:
duckplayer.youtube.overlayduckplayer.youtube.overlay.navigation.backis fired.duckplayer.youtube.overlay.navigation.refreshis fired.duckplayer.youtube.overlay.navigation.within-youtubeis fired.duckplayer.youtube.overlay.navigation.outside-youtubeis fired.Notes:
duckplayer.youtube.overlay.navigation.backis only fired when navigating directly to a video. Further back navigation willduckplayer.youtube.overlay.navigation.within-youtube. This is fine as we only want to track bounces on overlay after navigating directly to a video.