Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding custom bookmarks using AddOrEditBookmarkViewController #3410

Closed
wants to merge 4 commits into from

Conversation

dus7
Copy link
Contributor

@dus7 dus7 commented Sep 27, 2024

Task/Issue URL: https://app.asana.com/0/0/1208407775147560/f
Tech Design URL:
CC:

Description:

Description:

To allow adding custom favorites in Add Favorite flow, there are small changes in BSK required. Usage will be implemented in #3403.

Steps to test this PR:

  1. Open Debug menu and use the option at the end of the list to test the feature.
  2. Try adding bookmarks and favorites.

Definition of Done (Internal Only):


Internal references:

Software Engineering Expectations
Technical Design Template

@dus7 dus7 self-assigned this Sep 27, 2024
@dus7 dus7 marked this pull request as ready for review September 27, 2024 16:14
@dus7 dus7 requested a review from brindy September 27, 2024 16:14
Copy link

github-actions bot commented Oct 5, 2024

This PR has been inactive for more than 7 days and will be automatically closed 7 days from now.

@github-actions github-actions bot added the stale label Oct 5, 2024
@dus7 dus7 removed the stale label Oct 10, 2024
@dus7 dus7 closed this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant