Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix UI tests broken by tabs suggestions #3402

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

brindy
Copy link
Contributor

@brindy brindy commented Sep 26, 2024

Task/Issue URL: https://app.asana.com/0/392891325557410/1208408323212083/f
Tech Design URL:
CC:

Description:
Adding tabs to suggestions broke a test.
Maestro is behaving strangely in another test.

Steps to test this PR:

  1. Check the state of this end to end run: https://github.com/duckduckgo/iOS/actions/runs/11056977820
  • release tests should all pass, the other tests may pass if re-run but currently appear to be flakey
  1. Run release/ tests locally

@brindy brindy requested a review from loremattei September 26, 2024 17:15
Copy link
Contributor

@loremattei loremattei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests are still failing on CI, but this PR is contributing to improve the current situation, so I'd say it's safe to merge and take care of flakiness of the password tests in a subsequent one.

:shipit:

@graeme graeme merged commit db1140b into main Oct 4, 2024
18 of 22 checks passed
@graeme graeme deleted the brindy/fix-ui-tests-broken-by-tabs-suggestions branch October 4, 2024 14:59
samsymons added a commit that referenced this pull request Oct 9, 2024
* main:
  Update BSK version to support userTips NetP Flag (#3416)
  Release 7.140.0-0 (#3418)
  Adds new debug screen to view raw credentials data (#3400)
  Bump rollup from 2.79.1 to 3.29.5 (#3385)
  fix UI tests broken by tabs suggestions (#3402)
  Fix ability to edit Synced device name (#3404)
  Fix failing password-management maestro test (#3413)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants