Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump BSK which includes C.S.S 6.17 #3395

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Conversation

afterxleep
Copy link
Collaborator

@afterxleep afterxleep commented Sep 25, 2024

Task/Issue URL: https://app.asana.com/0/414235014887631/1208399924957022/f

Description:

  • Bumps C.S.S.

Steps to test this PR:

  1. C.S.S. Update has already been tested and approved here: DuckPlayer: Fix YouTube shorts issue #3392

@afterxleep afterxleep changed the title Bump BSK Bump BSK which includes C.S.S 6.17 Sep 25, 2024
@afterxleep afterxleep marked this pull request as ready for review September 25, 2024 20:04
afterxleep added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Sep 25, 2024
**Required**:

Task/Issue URL:
https://app.asana.com/0/414235014887631/1208399924957022/f
iOS PR: duckduckgo/iOS#3395
macOS PR: duckduckgo/macos-browser#3346
What kind of version bump will this require?: Minor

**Description**:
- Bump C.S.S to fix an issue with Youtube Shorts in Duck Player
@afterxleep afterxleep merged commit b7e0c62 into main Sep 25, 2024
13 checks passed
@afterxleep afterxleep deleted the daniel/duckplayer.bsk.fix branch September 25, 2024 21:26
samsymons added a commit that referenced this pull request Sep 28, 2024
# By Daniel Bernal (12) and others
# Via Daniel Bernal (5) and others
* main: (46 commits)
  Release 7.139.0-4 (#3411)
  Onboarding highlights experiment updates (#3406)
  fix suggestions performance (#3405)
  For third party requests differentiate if they are affiliated with first party (#3386)
  Bump BSK to pull in C-S-S 6.19.0 (#3396)
  Release 7.139.0-3 (#3399)
  Onboarding Highlights Ship Review  (#3380)
  add assertions for tabs in suggestions (#3394)
  Release 7.139.0-2 (#3398)
  Bump BSK to Include C.S.S 6.17 (#3397)
  Bump BSK which includes C.S.S 6.17 (#3395)
  Rever BSK branch
  Revert "Bump C.S.S"
  Bump C.S.S
  translations for Switch to Tab (#3391)
  Remove Favorites section header from NTP (#3381)
  Release 7.139.0-1 (#3389)
  Add origin to /apps URL (#3378)
  chery pick returning user fix
  Release 7.138.1-0 (#3388)
  ...

# Conflicts:
#	DuckDuckGo/AppDependencyProvider.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants