Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add assertions for tabs in suggestions #3394

Merged
merged 3 commits into from
Sep 25, 2024
Merged

add assertions for tabs in suggestions #3394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ed450a7
add test for tabs in suggestions
brindy Sep 25, 2024
ca0bd1c
check switching to tab from the new tab page closes the new tab page
brindy Sep 25, 2024
676b952
remove if from the steps
brindy Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/end-to-end.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,6 @@ jobs:

steps:
- name: Create Asana task when workflow failed
if: ${{ failure() }}
run: |
curl -s "https://app.asana.com/api/1.0/tasks" \
--header "Accept: application/json" \
Expand Down
44 changes: 44 additions & 0 deletions .maestro/release_tests/tabs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,27 @@ tags:
- assertVisible: ".*Privacy Test Pages.*"
- tapOn: "Refresh Page"

# Suggestions
- assertVisible:
id: "searchEntry"

- tapOn:
id: "searchEntry"
- inputText: "ad click"
- assertVisible: "Switch to Tab.*search-company.site"
- tapOn: "Switch to Tab.*search-company.site"
- assertVisible: ".*Ad Click Flow.*"

- tapOn:
id: "searchEntry"
- inputText: "privacy"
- assertVisible: "Switch to Tab.*privacy-test-pages.site"
- tapOn: "Switch to Tab.*privacy-test-pages.site"
- assertVisible: ".*Privacy Test Pages.*"

# Needed or else test can't see the Tab Switcher button for some reason
- tapOn: "Refresh Page"

# Close Tab
- assertVisible: Tab Switcher
- tapOn: Tab Switcher
Expand All @@ -57,3 +78,26 @@ tags:
- assertNotVisible: ".*Ad Click Flow.*"
- assertVisible: "1 Private Tab"
- tapOn: "Done"

# Switch tabs from new tab
- tapOn: "Refresh Page"
- assertVisible: Tab Switcher
- tapOn: Tab Switcher
- assertVisible: ".*Privacy Test Pages.*"
- assertVisible:
id: "Add"
- tapOn:
id: "Add"
- assertVisible:
id: "searchEntry"
- tapOn:
id: "searchEntry"
- inputText: "privacy"
- assertVisible: "Switch to Tab.*privacy-test-pages.site"
- tapOn: "Switch to Tab.*privacy-test-pages.site"
- assertVisible: ".*Privacy Test Pages.*"
- tapOn: "Refresh Page"
- assertVisible: Tab Switcher
- tapOn: Tab Switcher
- assertVisible: "1 Private Tab"

Loading