Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Balance calls for file presenter #3372

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Balance calls for file presenter #3372

merged 2 commits into from
Sep 19, 2024

Conversation

SlayterDev
Copy link
Contributor

@SlayterDev SlayterDev commented Sep 19, 2024

Task/Issue URL: https://app.asana.com/0/414709148257752/1208349795584311/f
Tech Design URL:
CC:

Description:

Steps to test this PR:

  1. See Balance calls for file presenter BrowserServicesKit#999

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@SlayterDev SlayterDev self-assigned this Sep 19, 2024
@SlayterDev SlayterDev marked this pull request as ready for review September 19, 2024 13:40
@SlayterDev SlayterDev merged commit 158d928 into main Sep 19, 2024
14 checks passed
@SlayterDev SlayterDev deleted the brad/config-manager-fix branch September 19, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants