Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to fix dissapearing privacy icon #3317

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Attempt to fix dissapearing privacy icon #3317

merged 1 commit into from
Sep 4, 2024

Conversation

jaceklyp
Copy link
Contributor

@jaceklyp jaceklyp commented Sep 4, 2024

Task/Issue URL: https://app.asana.com/0/414709148257752/1208225877520189/f

Description:
Fix disappearing privacy icon on sites without certificate.

Steps to test this PR:

  1. Go to any http:// site and make sure privacy icon is visible.

  2. Go to badssl.com

  3. Select expired certificate

  4. Our custom special error page should open.

  • please validate the privacy shield icon in navigation bar is invisible.
  1. Tap on leave site.
  • you should be taken back (if it was possible) or the tab should be closed if this was first page in navigation
  1. Go to badssl.com one more time and tap on advanced and accept the risk.
  • please validate that expired.badssl.com has loaded (red background)
  • please validate that privacy shield icon reappeared but has red dot on top of it
  1. Go to wrong.host.badssl.com and make sure icon is invisible.
  2. Go to cnn.com and make sure icon is visible.
  3. Go back and make sure icon is invisible.

THISISDINOSAUR
THISISDINOSAUR approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@THISISDINOSAUR THISISDINOSAUR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, when I first went to CNN the logo didn't appear until I refreshed, but I generally see similar inconsistent behavior with the icon (e.g. when turning protection on and off) before this issue

Simulator Screenshot - iPhone 15 Pro - 2024-09-04 at 16 27 29

@jaceklyp jaceklyp merged commit 2b2837e into release/7.136.0 Sep 4, 2024
16 checks passed
@jaceklyp jaceklyp deleted the jacek/fix-privacy-icon branch September 4, 2024 15:39
samsymons added a commit that referenced this pull request Sep 5, 2024
@samsymons
Merge branch 'release/7.136.0' into sam/release-pr-add-alternate-attr…
fb8f9cc 
…ibution-pixel

* release/7.136.0:
  Release 7.136.0-2 (#3320)
  Attempt to fix dissapearing privacy icon (#3317)
  Fix bookmarks toolbar behaviour with Sync Promo on iOS 15 (#3313)
samsymons added a commit that referenced this pull request Sep 9, 2024
@samsymons
Merge branch 'main' into sam/set-vpn-user-agent
a436229 
# By Christopher Brind (4) and others
# Via Alessandro Boron (1) and others
* main: (27 commits)
  Bump C-S-S to 6.14.1 (#3331)
  DuckPlayer Launch Experiment for iOS (#3328)
  defer loading the tab switcher button until view did load (#3326)
  Release 7.136.0-3 (#3324)
  Release PR: Check for the negative attribution case (#3311)
  fix tab switcher crashes (speculative fix) (#3319)
  Onboarding highlights feature flag setup (#3308)
  Release 7.136.0-2 (#3320)
  Attempt to fix dissapearing privacy icon (#3317)
  Fix bookmarks toolbar behaviour with Sync Promo on iOS 15 (#3313)
  Bump BSK with C-S-S to 6.14.0 (#3314)
  ensure no atb or app version sent with pixel (#3315)
  Fix #3298: Add support for Xcode 16 (#3299)
  Fix Keychain Debug view controller segue (#3310)
  Release 7.136.0-1 (#3309)
  Fix an issue that causes the fire dialog to show multiple times for the same website after dismissing it (#3305)
  [DuckPlayer] 28. Open in Youtube -> Youtube App (#3290)
  usage segmentation (#3263)
  Fix wrong URL displayed for auth dialog (#3307)
  iOS Integration of BSK Onboarding (#3282)
  ...

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@THISISDINOSAUR THISISDINOSAUR THISISDINOSAUR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaceklyp @THISISDINOSAUR