Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update attribution #3236

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Update attribution #3236

merged 2 commits into from
Aug 16, 2024

Conversation

samsymons
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/72649045549333/1208057751955788/f
Tech Design URL:
CC:

Description:

This PR adds support for AdAttributionKit.

Note: At the time of opening this PR, the release branch compilation is broken due to changes unrelated to this branch. I'll remove this comment once it's working again.

Steps to test this PR:

  1. Run this branch on a device and check that the attribution calls succeed to both SKAN4 and AdAttributionKit

Definition of Done (Internal Only):

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Internal references:

Software Engineering Expectations
Technical Design Template

* release/7.133.0:
  Release 7.133.0-1 (#3238)
  Fix failure to shut down VPN when subscription expires (#3237)
@jotaemepereira jotaemepereira requested review from jotaemepereira and removed request for federicocappelli August 15, 2024 13:18
Copy link
Contributor

@jotaemepereira jotaemepereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍🏼

// AppDelegate+Attribution.swift
// DuckDuckGo
//
// Copyright © 2023 DuckDuckGo. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Really minor: 2024 :)

@samsymons samsymons merged commit 70101ca into release/7.133.0 Aug 16, 2024
16 checks passed
@samsymons samsymons deleted the sam/adattributionkit-support branch August 16, 2024 01:33
samsymons added a commit that referenced this pull request Aug 16, 2024
* release/7.133.0:
  Release 7.133.0-2 (#3245)
  Update attribution (#3236)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants