New Tab Page post-review fixes #3221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix customize button area calculation
dus7
commented
Sep 12, 2024
| @@ -24,15 +24,14 @@ import Common | |||
|
|
|||
| struct FaviconsHelper { | |||
|
|
|||
| private static let tld: TLD = AppDependencyProvider.shared.storageCache.tld | |||
| private static let tld: TLD = AppDependencyProvider.shared.storageCache.tld | |||
|
|
|||
| static func loadFaviconSync(forDomain domain: String?, | |||
There was a problem hiding this comment.
The function says sync but there was no way to use the function without completion. I modified this one and added a version with completion for backwards compatibility.
| isLocalFlagEnabled && isFeatureFlagEnabled | ||
| let isLocalFlagInEffect = isLocalFlagEnabled && internalUserDecider.isInternalUser | ||
|
|
||
| return isLocalFlagInEffect || isFeatureFlagEnabled |
There was a problem hiding this comment.
Remote flag is now .remoteDevelopment, so either local flag needs to be set or enabled in privacy config, both only for internal users.
brindy
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1208023858138598/f
Tech Design URL:
CC:
Description:
This PR contains fixes for issues and glitches found for New Tab Page Improvements.
Steps to test this PR:
No specific steps but rather a set of things that were fixed/modified. Overall feature smoke check is required.
For a full list and details see completed subtasks of https://app.asana.com/0/72649045549333/1207539163549343/f.
Definition of Done (Internal Only):
Copy Testing:
’rather than'Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template