-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
application lock test and tab switcher test #3163
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚫 The Asana task linked in the PR description is not added to iOS App Board project.
|
github-actions
bot
added
the
bot: not in app board
Added by automation for pull requests with tasks not added to iOS App Board Asana project
label
Jul 30, 2024
loremattei
removed
the
bot: not in app board
Added by automation for pull requests with tasks not added to iOS App Board Asana project
label
Aug 1, 2024
loremattei
approved these changes
Aug 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good and tests are passing locally and on CI.
samsymons
added a commit
that referenced
this pull request
Aug 4, 2024
# By Alexey Martemyanov (2) and others # Via Alexey Martemyanov (2) and GitHub (1) * main: Enable favorites reordering on New Tab Page (#3169) [DuckPlayer]. 15. Move DuckPlayer code to BSK (#3171) Update autoconsent to v10.13.0 (#3178) application lock test and tab switcher test (#3163) Release 7.131.0-1 (#3179) restore CrashLogMessageExtractor with disabled __cxa_throw swapper (#3133) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
that referenced
this pull request
Aug 4, 2024
# By Alexey Martemyanov (2) and others # Via Alexey Martemyanov (2) and GitHub (1) * main: Add RMF `messageShown` attribute (#3176) Enable favorites reordering on New Tab Page (#3169) [DuckPlayer]. 15. Move DuckPlayer code to BSK (#3171) Update autoconsent to v10.13.0 (#3178) application lock test and tab switcher test (#3163) Release 7.131.0-1 (#3179) restore CrashLogMessageExtractor with disabled __cxa_throw swapper (#3133) Automatically add Asana task to iOS App Board (#3168) [DuckPlayer] 14. Potential fix to crash (#3161) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
that referenced
this pull request
Aug 5, 2024
# By Alexey Martemyanov (2) and others # Via Alexey Martemyanov (2) and GitHub (1) * main: Improve Bookmarks DB Setup (#3143) Add RMF `messageShown` attribute (#3176) Enable favorites reordering on New Tab Page (#3169) [DuckPlayer]. 15. Move DuckPlayer code to BSK (#3171) Update autoconsent to v10.13.0 (#3178) application lock test and tab switcher test (#3163) Release 7.131.0-1 (#3179) restore CrashLogMessageExtractor with disabled __cxa_throw swapper (#3133) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/392891325557410/1207589761442407/f
Tech Design URL:
CC:
Description:
UI tests for application lock and tab switcher.
Steps to test this PR: