Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

application lock test and tab switcher test #3163

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

brindy
Copy link
Contributor

@brindy brindy commented Jul 30, 2024

Task/Issue URL: https://app.asana.com/0/392891325557410/1207589761442407/f
Tech Design URL:
CC:

Description:
UI tests for application lock and tab switcher.

  • Some tab switcher stuff is covered by fire button and tabs tests already

Steps to test this PR:

  1. Check https://github.com/duckduckgo/iOS/actions/runs/10166644367 has passed
  2. Run release_tests/tabswitcher.yml
  3. Run release_tests/application-lock.yml

@brindy brindy requested a review from loremattei July 30, 2024 17:08
Copy link

🚫 The Asana task linked in the PR description is not added to iOS App Board project.

  1. Verify that the correct task is linked in the PR.
    • ⚠️ Please use the actual implementation task, rather than the Code Review subtask.
  2. Verify that the task is added to iOS App Board project.
  3. When ready, remove the bot: not in app board label to retrigger the check.

@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Jul 30, 2024
@loremattei loremattei removed the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Aug 1, 2024
Copy link
Contributor

@loremattei loremattei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and tests are passing locally and on CI.
:shipit:

@loremattei loremattei merged commit c7b9b09 into main Aug 2, 2024
19 of 21 checks passed
@loremattei loremattei deleted the brindy/application-lock-test branch August 2, 2024 13:01
samsymons added a commit that referenced this pull request Aug 4, 2024
# By Alexey Martemyanov (2) and others
# Via Alexey Martemyanov (2) and GitHub (1)
* main:
  Enable favorites reordering on New Tab Page (#3169)
  [DuckPlayer]. 15. Move DuckPlayer code to BSK (#3171)
  Update autoconsent to v10.13.0 (#3178)
  application lock test and tab switcher test (#3163)
  Release 7.131.0-1 (#3179)
  restore CrashLogMessageExtractor with disabled __cxa_throw swapper (#3133)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons added a commit that referenced this pull request Aug 4, 2024
# By Alexey Martemyanov (2) and others
# Via Alexey Martemyanov (2) and GitHub (1)
* main:
  Add RMF `messageShown` attribute (#3176)
  Enable favorites reordering on New Tab Page (#3169)
  [DuckPlayer]. 15. Move DuckPlayer code to BSK (#3171)
  Update autoconsent to v10.13.0 (#3178)
  application lock test and tab switcher test (#3163)
  Release 7.131.0-1 (#3179)
  restore CrashLogMessageExtractor with disabled __cxa_throw swapper (#3133)
  Automatically add Asana task to iOS App Board (#3168)
  [DuckPlayer] 14. Potential fix to crash (#3161)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons added a commit that referenced this pull request Aug 5, 2024
# By Alexey Martemyanov (2) and others
# Via Alexey Martemyanov (2) and GitHub (1)
* main:
  Improve Bookmarks DB Setup (#3143)
  Add RMF `messageShown` attribute (#3176)
  Enable favorites reordering on New Tab Page (#3169)
  [DuckPlayer]. 15. Move DuckPlayer code to BSK (#3171)
  Update autoconsent to v10.13.0 (#3178)
  application lock test and tab switcher test (#3163)
  Release 7.131.0-1 (#3179)
  restore CrashLogMessageExtractor with disabled __cxa_throw swapper (#3133)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants