Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Autofill UI test to reflect updated app copy #3158

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

amddg44
Copy link
Contributor

@amddg44 amddg44 commented Jul 29, 2024

Task/Issue URL: https://app.asana.com/0/414709148257752/1207921435391441/f
Tech Design URL:
CC:

Description:
Fixes failing UI test due to copy change

Steps to test this PR:

  1. Confirm End to End tests have passed: https://github.com/duckduckgo/iOS/actions/runs/10146698563
  2. Run run_ui_tests.sh release_tests/password-autofill.yaml and confirm test passes

Definition of Done (Internal Only):

Internal references:

Software Engineering Expectations
Technical Design Template

@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Jul 29, 2024
@amddg44 amddg44 requested a review from brindy July 29, 2024 15:22
Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - works locally. I can see you re-running the tests. If this works fine then feel free to merge. Thanks!

@amddg44 amddg44 removed the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Jul 29, 2024
@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Jul 29, 2024
@amddg44 amddg44 removed the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Jul 29, 2024
@amddg44 amddg44 merged commit b1dc390 into main Jul 29, 2024
38 of 43 checks passed
@amddg44 amddg44 deleted the anya/fix-autofill-ui-test branch July 29, 2024 19:01
samsymons added a commit that referenced this pull request Jul 31, 2024
# By Dominik Kapusta (3) and others
# Via GitHub
* main:
  New Tab Page Settings (#3140)
  New Tab Page Settings Storage (#3159)
  Prevent endless rekey and tunnel update cycle (#3091)
  tentatively fix content blocking UI test (#3141)
  Update Autofill UI test to reflect updated app copy (#3158)
  Duck player support on RMF (#3146)
  Release 7.131.0-0 (#3157)
  Update BSK with autofill 12.1.0 (#3155)
  Report Autofill issues via Passwords screen (#3116)
  Update GRDB to 2.4.0 (upstream 6.29.0, SQLCipher 4.6.0) (#3153)
  Update fastlane to 2.222.0 (#3154)
  [DuckPlayer] 13. Add openInfo message to Overlay (#3151)
  [DuckPlayer] 12. Ensure DuckPlayer does not leak without the proper config (#3147)
  [DuckPlayer] 11. Tab views and Pixel updates (#3145)
  Remove the NETWORK_PROTECTION compilation flag (#3139)
  Add favorites empty state tooltip (#3119)
  Bump submodules/privacy-reference-tests from `a603ff9` to `afb4f61` (#3113)
  iOS 14 deprecation cleanup (#3098)
  Update Xcode version to 15.4 (#3142)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons added a commit that referenced this pull request Aug 1, 2024
# By Dominik Kapusta (3) and others
# Via GitHub
* main:
  Automatically add Asana task to iOS App Board (#3168)
  [DuckPlayer] 14. Potential fix to crash (#3161)
  New Tab Page Settings (#3140)
  New Tab Page Settings Storage (#3159)
  Prevent endless rekey and tunnel update cycle (#3091)
  tentatively fix content blocking UI test (#3141)
  Update Autofill UI test to reflect updated app copy (#3158)
  Duck player support on RMF (#3146)
  Release 7.131.0-0 (#3157)
  Update BSK with autofill 12.1.0 (#3155)
  Report Autofill issues via Passwords screen (#3116)
  Update GRDB to 2.4.0 (upstream 6.29.0, SQLCipher 4.6.0) (#3153)
  Update fastlane to 2.222.0 (#3154)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants