Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug not clearing ui properly on autoclear #3050

Merged
merged 1 commit into from
Jul 5, 2024
Merged

fix bug not clearing ui properly on autoclear #3050

merged 1 commit into from
Jul 5, 2024

Conversation

brindy
Copy link
Contributor

@brindy brindy commented Jul 5, 2024

Task/Issue URL: https://app.asana.com/0/414709148257752/1207746141432859/f
Tech Design URL:
CC: @quanganhdo

Description:
Fixes bug with autoclear + timer that leaves previous URL on screen and does not attach Home Screen properly

Steps to test this PR:
Bug fix:

  1. Edit AutoClear.swift and set timer to clear after 5 seconds instead of 5 minutes in shouldClearData
  2. Enable autoclear plus 5 minute timer in setting
  3. Open a web page
  4. Background the app (do not terminate)
  5. Wait more than 5 seconds
  6. Foreground the app
  7. Data should be cleared and Home Screen should be attached and no URL visible in the bar

Smoke test:

  1. Test regular auto clear after terminate
  2. Test autoclear setting on and off
  3. Test fire button

@brindy brindy requested review from bwaresiak and quanganhdo July 5, 2024 19:00
@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Jul 5, 2024
@quanganhdo quanganhdo removed the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Jul 5, 2024
quanganhdo
quanganhdo approved these changes Jul 5, 2024
View reviewed changes
Copy link
Member

@quanganhdo quanganhdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my iPhone.

@quanganhdo quanganhdo merged commit d661bcb into release/7.127.0 Jul 5, 2024
25 of 28 checks passed
@quanganhdo quanganhdo deleted the brindy/fix-autoclear-after-timer branch July 5, 2024 20:32
samsymons added a commit that referenced this pull request Jul 7, 2024
@samsymons
Merge branch 'main' into sam/vpn-snooze-initial-support
4167d6f 
# By Christopher Brind (3) and others
# Via Anh Do (1) and GitHub (1)
* main:
  Add connection tester failure pixels (#3049)
  Release 7.127.0-1 (#3051)
  fix bug not clearing ui properly on autoclear (#3050)
  widget UI tests (#3042)
  fix autofill widget failure (#3040)
  macOS BSK change: De-duplicate passwords on import (#3048)
  Privacy Dashboard refactor (#3038)
  Make Maestro tests fail on flow cancellation (#3036)
  Improve VPN logging logic (#3032)
  Subscription refactoring #5 (#3023)
  Update Sync error pixels (#3046)
  Fixes App Data Clearing State Status In Settings (#3041)
  update sync error copy (#2870)
  Fixes for Xcode 16 (BSK -> 164.3.0) (#3035)
  Update the Privacy Pro status attribute matcher (#3033)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quanganhdo quanganhdo quanganhdo approved these changes

@bwaresiak bwaresiak Awaiting requested review from bwaresiak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brindy @quanganhdo