Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix widget part of autofill ui test #3037

Closed
wants to merge 14 commits into from
Closed

Conversation

brindy
Copy link
Contributor

@brindy brindy commented Jul 4, 2024

Task/Issue URL: https://app.asana.com/0/0/1207729188744402/f
Tech Design URL:
CC:

Description:
Use iOS 17.0 (to match CI) and quote strings.

Disable widget part of the test for now as it seems broke on iOS 17 (when run on mobile.dev)

Steps to test this PR:

  1. Check password-authentication release task passes https://github.com/duckduckgo/iOS/actions/runs/9796687524
  2. Run password-authentication.yaml test and make sure it passes locally

@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Jul 4, 2024
@brindy brindy marked this pull request as ready for review July 4, 2024 13:43
@brindy brindy requested a review from loremattei July 4, 2024 13:43
@brindy brindy removed the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Jul 4, 2024
@loremattei
Copy link
Contributor

@brindy unfortunately it looks like the password-authentication test got cancelled again 😰

@brindy
Copy link
Contributor Author

brindy commented Jul 4, 2024

@loremattei - have disabled it now as it seems incompatible with iOS 17.0 as we discussed (and there doesn't seem to be a way to specify the exact iOS version on mobile.dev)

@brindy
Copy link
Contributor Author

brindy commented Jul 4, 2024

I messed something up here. Closing out and will re-open

@brindy brindy closed this Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants