Subscription refactoring #5 #3023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
3 tasks
afterxleep
approved these changes
Jul 4, 2024
There was a problem hiding this comment.
Hopefully you can get rid of this one now that Sam merged the iOS 14 drop?
There was a problem hiding this comment.
YES! I already have a stash with all changes, I'm just waiting for Sam's modifications to be live, I would like to avoid a cherry pick if something goes wrong with the iOS 14 drop
| final class SubscriptionPagesUseSubscriptionFeatureTests: XCTestCase { | ||
|
|
||
| override func setUpWithError() throws { | ||
| // Put setup code here. This method is called before the invocation of each test method in the class. |
There was a problem hiding this comment.
Remove these if not used?
federicocappelli
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Jul 5, 2024
Task/Issue URL: https://app.asana.com/0/1205842942115003/1206805455884775/f iOS PR: duckduckgo/iOS#3023 macOS PR: duckduckgo/macos-browser#2930 What kind of version bump will this require?: Major Tech Design URL: https://app.asana.com/0/1205842942115003/1207147511614062/f Dependency injection for many Subscription classes has been improved to allow unit tests. Many test classes have been created and one or more example tests have been implemented to showcase the class testability and mocks Complete tests will be implemented in follow-up tasks
Merge branch 'main' into fcappelli/subscription_refactoring_5 # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
that referenced
this pull request
Jul 7, 2024
# By Christopher Brind (3) and others # Via Anh Do (1) and GitHub (1) * main: Add connection tester failure pixels (#3049) Release 7.127.0-1 (#3051) fix bug not clearing ui properly on autoclear (#3050) widget UI tests (#3042) fix autofill widget failure (#3040) macOS BSK change: De-duplicate passwords on import (#3048) Privacy Dashboard refactor (#3038) Make Maestro tests fail on flow cancellation (#3036) Improve VPN logging logic (#3032) Subscription refactoring #5 (#3023) Update Sync error pixels (#3046) Fixes App Data Clearing State Status In Settings (#3041) update sync error copy (#2870) Fixes for Xcode 16 (BSK -> 164.3.0) (#3035) Update the Privacy Pro status attribute matcher (#3033) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1205842942115003/1206805455884775/f
Tech Design URL: https://app.asana.com/0/1205842942115003/1207147511614062/f
CC: @miasma13
Description:
This PR updates BSK from duckduckgo/BrowserServicesKit#874 and contains all the needed refactoring for the Subscription classes inits.
It also contains a new unit test class:
Complete tests will be implemented in follow-up tasks
Steps to test this PR:
Subscription must work as usual, manual smoke test script available in this README
Definition of Done (Internal Only):
Device Testing:
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template